Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA289106F8 for ; Wed, 26 Aug 2015 02:06:24 +0000 (UTC) Received: (qmail 21001 invoked by uid 500); 26 Aug 2015 02:06:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20950 invoked by uid 500); 26 Aug 2015 02:06:24 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 20920 invoked by uid 99); 26 Aug 2015 02:06:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 02:06:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A11A126B7D0; Wed, 26 Aug 2015 02:06:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6744337304824914994==" MIME-Version: 1.0 Subject: Re: Review Request 37776: Setting revocable flag on a TaskInfo. From: "Bill Farner" To: "Bill Farner" , "Zameer Manji" Cc: "Maxim Khutornenko" , "Aurora" Date: Wed, 26 Aug 2015 02:06:23 -0000 Message-ID: <20150826020623.13584.83703@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37776/ X-Sender: "Bill Farner" References: <20150825230503.13583.4554@reviews.apache.org> In-Reply-To: <20150825230503.13583.4554@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============6744337304824914994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/#review96480 ----------------------------------------------------------- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 4:05 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37776/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 4:05 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > In order to be launched by Mesos a BE task resources must have a `revocable` flag set. The ExecutorInfo revocable flag is not strictly necessary but using the same approach simplifies resource handling. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/Offers.java 9f3ce1643c583ea4160478c57da9c559beb38c4a > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e5953bbf02fc2b08fbdff5c25b5389c5a209dfca > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ff6eb980292c05e35dcf68104c870a7bef95629a > src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 50e7fc91108993e547869df5b9e5c925fb89a225 > src/test/java/org/apache/aurora/scheduler/ResourcesTest.java c48d0968970601b86b2e99cc1e3defaddd24bf28 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 02fe96445148d1e14d85dc7a6fa386d84a8a8c70 > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 8a1599a0c71bc598bb19c69a36bb380d49387710 > > Diff: https://reviews.apache.org/r/37776/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > > --===============6744337304824914994==--