Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E6D118C07 for ; Fri, 21 Aug 2015 18:04:45 +0000 (UTC) Received: (qmail 69202 invoked by uid 500); 21 Aug 2015 18:04:45 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 69152 invoked by uid 500); 21 Aug 2015 18:04:45 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 69117 invoked by uid 99); 21 Aug 2015 18:04:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Aug 2015 18:04:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 67D111CCB1C; Fri, 21 Aug 2015 18:04:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4014127990072352492==" MIME-Version: 1.0 Subject: Re: Review Request 37666: Import of Twitter Commons. From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" , "Maxim Khutornenko" , "Jake Farrell" Cc: "Zameer Manji" , "Aurora" Date: Fri, 21 Aug 2015 18:04:44 -0000 Message-ID: <20150821180444.1483.142@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37666/ X-Sender: "Maxim Khutornenko" References: <20150821010531.1483.15129@reviews.apache.org> In-Reply-To: <20150821010531.1483.15129@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora --===============4014127990072352492== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96062 ----------------------------------------------------------- It would be great to preserve all commit history with this import. Any chance you could follow the sapling split procedure? It's a bit involved but pretty well documented here: https://github.com/jsirois/sapling - Maxim Khutornenko On Aug. 21, 2015, 1:04 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37666/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 1:04 a.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. > > > Bugs: AURORA-1213 > https://issues.apache.org/jira/browse/AURORA-1213 > > > Repository: aurora > > > Description > ------- > > This patch imports the Java portion of Twitter Commons into our tree. It copies > the following files from sha bc7248d: > ```` > src/java/com/twitter/common/application/AbstractApplication.java > src/java/com/twitter/common/application/AppLauncher.java > src/java/com/twitter/common/application/Application.java > src/java/com/twitter/common/application/http/DefaultQuitHandler.java > src/java/com/twitter/common/application/http/GraphViewer.java > src/java/com/twitter/common/application/http/HttpAssetConfig.java > src/java/com/twitter/common/application/http/HttpFilterConfig.java > src/java/com/twitter/common/application/http/HttpServletConfig.java > src/java/com/twitter/common/application/http/Registration.java > src/java/com/twitter/common/application/Lifecycle.java > src/java/com/twitter/common/application/modules/AppLauncherModule.java > src/java/com/twitter/common/application/modules/LifecycleModule.java > src/java/com/twitter/common/application/modules/LocalServiceRegistry.java > src/java/com/twitter/common/application/modules/LogModule.java > src/java/com/twitter/common/application/modules/StatsExportModule.java > src/java/com/twitter/common/application/modules/StatsModule.java > src/java/com/twitter/common/application/modules/ThriftModule.java > src/java/com/twitter/common/application/ShutdownRegistry.java > src/java/com/twitter/common/application/ShutdownStage.java > src/java/com/twitter/common/application/StartupRegistry.java > src/java/com/twitter/common/application/StartupStage.java > src/java/com/twitter/common/args/apt/CmdLineProcessor.java > src/java/com/twitter/common/args/apt/Configuration.java > src/java/com/twitter/common/args/Arg.java > src/java/com/twitter/common/args/ArgFilters.java > src/java/com/twitter/common/args/ArgParser.java > src/java/com/twitter/common/args/Args.java > src/java/com/twitter/common/args/ArgScanner.java > src/java/com/twitter/common/args/ArgumentInfo.java > src/java/com/twitter/common/args/CmdLine.java > src/java/com/twitter/common/args/constraints/CanExecute.java > src/java/com/twitter/common/args/constraints/CanExecuteFileVerifier.java > src/java/com/twitter/common/args/constraints/CanRead.java > src/java/com/twitter/common/args/constraints/CanReadFileVerifier.java > src/java/com/twitter/common/args/constraints/CanWrite.java > src/java/com/twitter/common/args/constraints/CanWriteFileVerifier.java > src/java/com/twitter/common/args/constraints/Exists.java > src/java/com/twitter/common/args/constraints/ExistsFileVerifier.java > src/java/com/twitter/common/args/constraints/IsDirectory.java > src/java/com/twitter/common/args/constraints/IsDirectoryFileVerifier.java > src/java/com/twitter/common/args/constraints/NotEmpty.java > src/java/com/twitter/common/args/constraints/NotEmptyIterableVerifier.java > src/java/com/twitter/common/args/constraints/NotEmptyStringVerifier.java > src/java/com/twitter/common/args/constraints/NotNegative.java > src/java/com/twitter/common/args/constraints/NotNegativeNumberVerifier.java > src/java/com/twitter/common/args/constraints/NotNull.java > src/java/com/twitter/common/args/constraints/NotNullVerifier.java > src/java/com/twitter/common/args/constraints/Positive.java > src/java/com/twitter/common/args/constraints/PositiveNumberVerifier.java > src/java/com/twitter/common/args/constraints/Range.java > src/java/com/twitter/common/args/constraints/RangeNumberVerifier.java > src/java/com/twitter/common/args/NoParser.java > src/java/com/twitter/common/args/OptionInfo.java > src/java/com/twitter/common/args/Parser.java > src/java/com/twitter/common/args/ParserOracle.java > src/java/com/twitter/common/args/parsers/AmountParser.java > src/java/com/twitter/common/args/parsers/BooleanParser.java > src/java/com/twitter/common/args/parsers/ByteParser.java > src/java/com/twitter/common/args/parsers/CharacterParser.java > src/java/com/twitter/common/args/parsers/ClassParser.java > src/java/com/twitter/common/args/parsers/DateParser.java > src/java/com/twitter/common/args/parsers/DoubleParser.java > src/java/com/twitter/common/args/parsers/DurationParser.java > src/java/com/twitter/common/args/parsers/EnumParser.java > src/java/com/twitter/common/args/parsers/FileParser.java > src/java/com/twitter/common/args/parsers/FloatParser.java > src/java/com/twitter/common/args/parsers/InetSocketAddressParser.java > src/java/com/twitter/common/args/parsers/IntegerParser.java > src/java/com/twitter/common/args/parsers/ListParser.java > src/java/com/twitter/common/args/parsers/LongParser.java > src/java/com/twitter/common/args/parsers/MapParser.java > src/java/com/twitter/common/args/parsers/NonParameterizedTypeParser.java > src/java/com/twitter/common/args/parsers/NumberParser.java > src/java/com/twitter/common/args/parsers/PairParser.java > src/java/com/twitter/common/args/parsers/PatternParser.java > src/java/com/twitter/common/args/parsers/RangeParser.java > src/java/com/twitter/common/args/parsers/SetParser.java > src/java/com/twitter/common/args/parsers/ShortParser.java > src/java/com/twitter/common/args/parsers/StringParser.java > src/java/com/twitter/common/args/parsers/TypeParameterizedParser.java > src/java/com/twitter/common/args/parsers/UnitParser.java > src/java/com/twitter/common/args/parsers/URIParser.java > src/java/com/twitter/common/args/parsers/URLParser.java > src/java/com/twitter/common/args/Parsers.java > src/java/com/twitter/common/args/Positional.java > src/java/com/twitter/common/args/PositionalInfo.java > src/java/com/twitter/common/args/TypeUtil.java > src/java/com/twitter/common/args/Verifier.java > src/java/com/twitter/common/args/VerifierFor.java > src/java/com/twitter/common/args/Verifiers.java > src/java/com/twitter/common/base/CachingSupplier.java > src/java/com/twitter/common/base/CallableExceptionalSupplier.java > src/java/com/twitter/common/base/Closure.java > src/java/com/twitter/common/base/Closures.java > src/java/com/twitter/common/base/Command.java > src/java/com/twitter/common/base/Commands.java > src/java/com/twitter/common/base/Either.java > src/java/com/twitter/common/base/ExceptionalClosure.java > src/java/com/twitter/common/base/ExceptionalCommand.java > src/java/com/twitter/common/base/ExceptionalFunction.java > src/java/com/twitter/common/base/ExceptionalFunctions.java > src/java/com/twitter/common/base/ExceptionalSupplier.java > src/java/com/twitter/common/base/ExceptionTransporter.java > src/java/com/twitter/common/base/Function.java > src/java/com/twitter/common/base/MorePreconditions.java > src/java/com/twitter/common/base/MoreSuppliers.java > src/java/com/twitter/common/base/Supplier.java > src/java/com/twitter/common/base/SupplierE.java > src/java/com/twitter/common/collections/Bits.java > src/java/com/twitter/common/collections/BoundedQueue.java > src/java/com/twitter/common/collections/Iterables2.java > src/java/com/twitter/common/collections/Multimaps.java > src/java/com/twitter/common/collections/Pair.java > src/java/com/twitter/common/inject/Bindings.java > src/java/com/twitter/common/inject/DefaultProvider.java > src/java/com/twitter/common/inject/ProviderMethodModule.java > src/java/com/twitter/common/inject/TimedInterceptor.java > src/java/com/twitter/common/io/Base64ZlibCodec.java > src/java/com/twitter/common/io/Codec.java > src/java/com/twitter/common/io/CompatibilityCodec.java > src/java/com/twitter/common/io/FileUtils.java > src/java/com/twitter/common/io/JsonCodec.java > src/java/com/twitter/common/io/Streamer.java > src/java/com/twitter/common/io/ThriftCodec.java > src/java/com/twitter/common/logging/BufferedLog.java > src/java/com/twitter/common/logging/Glog.java > src/java/com/twitter/common/logging/julbridge/JULBridgeHandler.java > src/java/com/twitter/common/logging/julbridge/JULBridgeLevelConverter.java > src/java/com/twitter/common/logging/julbridge/JULBridgeLogManager.java > src/java/com/twitter/common/logging/Log.java > src/java/com/twitter/common/logging/log4j/GlogLayout.java > src/java/com/twitter/common/logging/LogFormatter.java > src/java/com/twitter/common/logging/LogUtil.java > src/java/com/twitter/common/logging/RootLogConfig.java > src/java/com/twitter/common/net/Environment.java > src/java/com/twitter/common/net/http/filters/AbstractHttpFilter.java > src/java/com/twitter/common/net/http/filters/HttpStatsFilter.java > src/java/com/twitter/common/net/http/GuiceServletConfig.java > src/java/com/twitter/common/net/http/handlers/AbortHandler.java > src/java/com/twitter/common/net/http/handlers/AssetHandler.java > src/java/com/twitter/common/net/http/handlers/ContentionPrinter.java > src/java/com/twitter/common/net/http/handlers/HealthHandler.java > src/java/com/twitter/common/net/http/handlers/HttpServletRequestParams.java > src/java/com/twitter/common/net/http/handlers/LogConfig.java > src/java/com/twitter/common/net/http/handlers/LogPrinter.java > src/java/com/twitter/common/net/http/handlers/QuitHandler.java > src/java/com/twitter/common/net/http/handlers/StringTemplateServlet.java > src/java/com/twitter/common/net/http/handlers/TextResponseHandler.java > src/java/com/twitter/common/net/http/handlers/ThreadStackPrinter.java > src/java/com/twitter/common/net/http/handlers/ThriftServlet.java > src/java/com/twitter/common/net/http/handlers/TimeSeriesDataSource.java > src/java/com/twitter/common/net/http/handlers/VarsHandler.java > src/java/com/twitter/common/net/http/handlers/VarsJsonHandler.java > src/java/com/twitter/common/net/http/HttpServerDispatch.java > src/java/com/twitter/common/net/http/JettyHttpServerDispatch.java > src/java/com/twitter/common/net/http/RequestLogger.java > src/java/com/twitter/common/net/InetSocketAddressHelper.java > src/java/com/twitter/common/net/loadbalancing/LeastConnectedStrategy.java > src/java/com/twitter/common/net/loadbalancing/LoadBalancer.java > src/java/com/twitter/common/net/loadbalancing/LoadBalancerImpl.java > src/java/com/twitter/common/net/loadbalancing/LoadBalancingStrategy.java > src/java/com/twitter/common/net/loadbalancing/MarkDeadStrategy.java > src/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyWithHostCheck.java > src/java/com/twitter/common/net/loadbalancing/RandomStrategy.java > src/java/com/twitter/common/net/loadbalancing/RequestTracker.java > src/java/com/twitter/common/net/loadbalancing/RoundRobinStrategy.java > src/java/com/twitter/common/net/loadbalancing/StaticLoadBalancingStrategy.java > src/java/com/twitter/common/net/loadbalancing/SubsetStrategy.java > src/java/com/twitter/common/net/loadbalancing/TrafficMonitorAdapter.java > src/java/com/twitter/common/net/monitoring/ConnectionMonitor.java > src/java/com/twitter/common/net/monitoring/TrafficMonitor.java > src/java/com/twitter/common/net/pool/Connection.java > src/java/com/twitter/common/net/pool/ConnectionFactory.java > src/java/com/twitter/common/net/pool/ConnectionPool.java > src/java/com/twitter/common/net/pool/DynamicHostSet.java > src/java/com/twitter/common/net/pool/DynamicHostSetUtil.java > src/java/com/twitter/common/net/pool/DynamicPool.java > src/java/com/twitter/common/net/pool/MetaPool.java > src/java/com/twitter/common/net/pool/ObjectPool.java > src/java/com/twitter/common/net/pool/ResourceExhaustedException.java > src/java/com/twitter/common/net/ProxyAuthorizer.java > src/java/com/twitter/common/net/ProxyConfig.java > src/java/com/twitter/common/net/UrlHelper.java > src/java/com/twitter/common/net/UrlResolver.java > src/java/com/twitter/common/net/UrlResolverUtil.java > src/java/com/twitter/common/net/UrlTokenizerUtil.java > src/java/com/twitter/common/objectsize/ObjectSizeCalculator.java > src/java/com/twitter/common/quantity/Amount.java > src/java/com/twitter/common/quantity/Data.java > src/java/com/twitter/common/quantity/Time.java > src/java/com/twitter/common/quantity/Unit.java > src/java/com/twitter/common/stats/ApproximateHistogram.java > src/java/com/twitter/common/stats/CounterMap.java > src/java/com/twitter/common/stats/CounterMapWithTopKey.java > src/java/com/twitter/common/stats/Elapsed.java > src/java/com/twitter/common/stats/Entropy.java > src/java/com/twitter/common/stats/Histogram.java > src/java/com/twitter/common/stats/Histograms.java > src/java/com/twitter/common/stats/JvmStats.java > src/java/com/twitter/common/stats/MovingAverage.java > src/java/com/twitter/common/stats/MovingWindowDelta.java > src/java/com/twitter/common/stats/NumericStatExporter.java > src/java/com/twitter/common/stats/Percentile.java > src/java/com/twitter/common/stats/PipelineStats.java > src/java/com/twitter/common/stats/Precision.java > src/java/com/twitter/common/stats/PrintableHistogram.java > src/java/com/twitter/common/stats/Rate.java > src/java/com/twitter/common/stats/Ratio.java > src/java/com/twitter/common/stats/RecordingStat.java > src/java/com/twitter/common/stats/RecordingStatImpl.java > src/java/com/twitter/common/stats/RequestStats.java > src/java/com/twitter/common/stats/ReservoirSampler.java > src/java/com/twitter/common/stats/SampledStat.java > src/java/com/twitter/common/stats/Significance.java > src/java/com/twitter/common/stats/SlidingStats.java > src/java/com/twitter/common/stats/Stat.java > src/java/com/twitter/common/stats/StatImpl.java > src/java/com/twitter/common/stats/Statistics.java > src/java/com/twitter/common/stats/StatisticsInterface.java > src/java/com/twitter/common/stats/StatRegistry.java > src/java/com/twitter/common/stats/Stats.java > src/java/com/twitter/common/stats/StatsProvider.java > src/java/com/twitter/common/stats/testing/RealHistogram.java > src/java/com/twitter/common/stats/TimeSeries.java > src/java/com/twitter/common/stats/TimeSeriesRepository.java > src/java/com/twitter/common/stats/TimeSeriesRepositoryImpl.java > src/java/com/twitter/common/stats/Windowed.java > src/java/com/twitter/common/stats/WindowedApproxHistogram.java > src/java/com/twitter/common/stats/WindowedHistogram.java > src/java/com/twitter/common/stats/WindowedStatistics.java > src/java/com/twitter/common/testing/easymock/EasyMockTest.java > src/java/com/twitter/common/testing/easymock/IterableEquals.java > src/java/com/twitter/common/testing/junit/rules/Retry.java > src/java/com/twitter/common/testing/mockito/MockitoTest.java > src/java/com/twitter/common/testing/TearDownRegistry.java > src/java/com/twitter/common/thrift/callers/Caller.java > src/java/com/twitter/common/thrift/callers/CallerDecorator.java > src/java/com/twitter/common/thrift/callers/DeadlineCaller.java > src/java/com/twitter/common/thrift/callers/DebugCaller.java > src/java/com/twitter/common/thrift/callers/RetryingCaller.java > src/java/com/twitter/common/thrift/callers/StatTrackingCaller.java > src/java/com/twitter/common/thrift/callers/ThriftCaller.java > src/java/com/twitter/common/thrift/Config.java > src/java/com/twitter/common/thrift/monitoring/TMonitoredNonblockingServerSocket.java > src/java/com/twitter/common/thrift/monitoring/TMonitoredProcessor.java > src/java/com/twitter/common/thrift/monitoring/TMonitoredServerSocket.java > src/java/com/twitter/common/thrift/testing/MockTSocket.java > src/java/com/twitter/common/thrift/testing/TestThriftTypes.java > src/java/com/twitter/common/thrift/Thrift.java > src/java/com/twitter/common/thrift/ThriftConnectionFactory.java > src/java/com/twitter/common/thrift/ThriftException.java > src/java/com/twitter/common/thrift/ThriftFactory.java > src/java/com/twitter/common/thrift/TResourceExhaustedException.java > src/java/com/twitter/common/thrift/TTimeoutException.java > src/java/com/twitter/common/thrift/TTransportConnection.java > src/java/com/twitter/common/thrift/Util.java > src/java/com/twitter/common/util/BackoffDecider.java > src/java/com/twitter/common/util/BackoffHelper.java > src/java/com/twitter/common/util/BackoffStrategy.java > src/java/com/twitter/common/util/BuildInfo.java > src/java/com/twitter/common/util/caching/Cache.java > src/java/com/twitter/common/util/caching/CachingMethodProxy.java > src/java/com/twitter/common/util/caching/LRUCache.java > src/java/com/twitter/common/util/Clock.java > src/java/com/twitter/common/util/CommandExecutor.java > src/java/com/twitter/common/util/concurrent/BackingOffFutureTask.java > src/java/com/twitter/common/util/concurrent/ExceptionHandlingExecutorService.java > src/java/com/twitter/common/util/concurrent/ExceptionHandlingScheduledExecutorService.java > src/java/com/twitter/common/util/concurrent/ExecutorServiceShutdown.java > src/java/com/twitter/common/util/concurrent/ForwardingExecutorService.java > src/java/com/twitter/common/util/concurrent/MoreExecutors.java > src/java/com/twitter/common/util/concurrent/RetryingFutureTask.java > src/java/com/twitter/common/util/concurrent/TaskConverter.java > src/java/com/twitter/common/util/DateUtils.java > src/java/com/twitter/common/util/FileUtils.java > src/java/com/twitter/common/util/logging/ResourceLoggingConfigurator.java > src/java/com/twitter/common/util/logging/UnresettableLogManager.java > src/java/com/twitter/common/util/LowResClock.java > src/java/com/twitter/common/util/ParsingUtil.java > src/java/com/twitter/common/util/QueueDrainer.java > src/java/com/twitter/common/util/Random.java > src/java/com/twitter/common/util/RangeNormalizer.java > src/java/com/twitter/common/util/RateLimitedCommandExecutor.java > src/java/com/twitter/common/util/RetryingRunnable.java > src/java/com/twitter/common/util/Sampler.java > src/java/com/twitter/common/util/StartWatch.java > src/java/com/twitter/common/util/Stat.java > src/java/com/twitter/common/util/StateMachine.java > src/java/com/twitter/common/util/templating/StringTemplateHelper.java > src/java/com/twitter/common/util/testing/FakeClock.java > src/java/com/twitter/common/util/testing/FakeTicker.java > src/java/com/twitter/common/util/Timer.java > src/java/com/twitter/common/util/TruncatedBinaryBackoff.java > src/java/com/twitter/common/webassets/bootstrap/BootstrapModule.java > src/java/com/twitter/common/webassets/jquery/JQueryModule.java > src/java/com/twitter/common/zookeeper/Candidate.java > src/java/com/twitter/common/zookeeper/CandidateImpl.java > src/java/com/twitter/common/zookeeper/CompoundServerSet.java > src/java/com/twitter/common/zookeeper/DistributedLock.java > src/java/com/twitter/common/zookeeper/DistributedLockImpl.java > src/java/com/twitter/common/zookeeper/Group.java > src/java/com/twitter/common/zookeeper/guice/client/flagged/FlaggedClientConfig.java > src/java/com/twitter/common/zookeeper/guice/client/ZooKeeperClientModule.java > src/java/com/twitter/common/zookeeper/guice/ServerSetModule.java > src/java/com/twitter/common/zookeeper/Partitioner.java > src/java/com/twitter/common/zookeeper/ServerSet.java > src/java/com/twitter/common/zookeeper/ServerSetImpl.java > src/java/com/twitter/common/zookeeper/ServerSets.java > src/java/com/twitter/common/zookeeper/SingletonService.java > src/java/com/twitter/common/zookeeper/StaticServerSet.java > src/java/com/twitter/common/zookeeper/testing/BaseZooKeeperTest.java > src/java/com/twitter/common/zookeeper/testing/ZooKeeperTestServer.java > src/java/com/twitter/common/zookeeper/ZooKeeperClient.java > src/java/com/twitter/common/zookeeper/ZooKeeperMap.java > src/java/com/twitter/common/zookeeper/ZooKeeperNode.java > src/java/com/twitter/common/zookeeper/ZooKeeperUtils.java > src/resources/com/twitter/common/application/http/graphview/dygraph-combined.js > src/resources/com/twitter/common/application/http/graphview/dygraph-extra.js > src/resources/com/twitter/common/application/http/graphview/grapher.js > src/resources/com/twitter/common/application/http/graphview/graphview.html > src/resources/com/twitter/common/application/http/graphview/parser.js > src/resources/com/twitter/common/net/http/handlers/logconfig.st > src/resources/com/twitter/common/net/http/handlers/logprinter.st > src/resources/com/twitter/common/net/http/handlers/thrift.st > src/resources/com/twitter/common/webassets/bootstrap/2.1.1/css/bootstrap-responsive.min.css > src/resources/com/twitter/common/webassets/bootstrap/2.1.1/css/bootstrap.min.css > src/resources/com/twitter/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings-white.png > src/resources/com/twitter/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings.png > src/resources/com/twitter/common/webassets/bootstrap/2.1.1/js/bootstrap.min.js > src/resources/com/twitter/common/webassets/bootstrap/2.3.2/css/bootstrap-responsive.min.css > src/resources/com/twitter/common/webassets/bootstrap/2.3.2/css/bootstrap.min.css > src/resources/com/twitter/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings-white.png > src/resources/com/twitter/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings.png > src/resources/com/twitter/common/webassets/bootstrap/2.3.2/js/bootstrap.min.js > src/resources/com/twitter/common/webassets/jquery/js/jquery-1.8.2.min.js > src/thrift/com/twitter/thrift/endpoint.thrift > tests/java/com/twitter/common/application/AppLauncherTest.java > tests/java/com/twitter/common/application/modules/LifecycleModuleTest.java > tests/java/com/twitter/common/application/modules/LocalServiceRegistryTest.java > tests/java/com/twitter/common/application/modules/StartStatPollerTest.java > tests/java/com/twitter/common/args/argfilterstest/ArgsRoot.java > tests/java/com/twitter/common/args/argfilterstest/subpackageA/ArgsA.java > tests/java/com/twitter/common/args/argfilterstest/subpackageA/subsubpackage1/ArgsA1.java > tests/java/com/twitter/common/args/argfilterstest/subpackageB/ArgsB.java > tests/java/com/twitter/common/args/argfilterstest/subpackageBwithSuffix/ArgsBWithSuffix.java > tests/java/com/twitter/common/args/ArgFiltersTest.java > tests/java/com/twitter/common/args/ArgScannerTest.java > tests/java/com/twitter/common/args/ArgsTest.java > tests/java/com/twitter/common/args/ArgTest.java > tests/java/com/twitter/common/args/OptionInfoTest.java > tests/java/com/twitter/common/args/ParsersTest.java > tests/java/com/twitter/common/base/CachingSupplierTest.java > tests/java/com/twitter/common/base/ClosuresTest.java > tests/java/com/twitter/common/base/CommandsTest.java > tests/java/com/twitter/common/base/EitherTest.java > tests/java/com/twitter/common/base/ExceptionalFunctionsTest.java > tests/java/com/twitter/common/base/ExceptionTransporterTest.java > tests/java/com/twitter/common/base/MorePreconditionsTest.java > tests/java/com/twitter/common/base/MoreSuppliersTest.java > tests/java/com/twitter/common/collections/BitsTest.java > tests/java/com/twitter/common/collections/BoundedQueueTest.java > tests/java/com/twitter/common/collections/Iterables2Test.java > tests/java/com/twitter/common/collections/PairTest.java > tests/java/com/twitter/common/inject/BindingsTest.java > tests/java/com/twitter/common/inject/DefaultProviderTest.java > tests/java/com/twitter/common/io/Base64ZlibCodecTest.java > tests/java/com/twitter/common/io/CodecTestUtilities.java > tests/java/com/twitter/common/io/CompatibilityCodecTest.java > tests/java/com/twitter/common/io/FileUtilsTest.java > tests/java/com/twitter/common/io/JsonCodecTest.java > tests/java/com/twitter/common/io/ThriftCodecTest.java > tests/java/com/twitter/common/logging/BufferedLogTest.java > tests/java/com/twitter/common/logging/julbridge/JULBridgeHandlerTest.java > tests/java/com/twitter/common/logging/julbridge/JULBridgeLevelConverterTest.java > tests/java/com/twitter/common/logging/julbridge/JULBridgeLogManagerTest.java > tests/java/com/twitter/common/logging/LogFormatterTest.java > tests/java/com/twitter/common/logging/LogUtilTest.java > tests/java/com/twitter/common/logging/RootLogConfigTest.java > tests/java/com/twitter/common/net/http/filters/HttpStatsFilterIntegrationTest.java > tests/java/com/twitter/common/net/http/filters/HttpStatsFilterTest.java > tests/java/com/twitter/common/net/http/handlers/AssetHandlerTest.java > tests/java/com/twitter/common/net/http/handlers/HttpServletRequestParamsTest.java > tests/java/com/twitter/common/net/http/handlers/LogPrinterTest.java > tests/java/com/twitter/common/net/http/handlers/StatSupplierTestBase.java > tests/java/com/twitter/common/net/http/handlers/TimeSeriesDataSourceTest.java > tests/java/com/twitter/common/net/http/handlers/VarsHandlerTest.java > tests/java/com/twitter/common/net/http/handlers/VarsJsonHandlerTest.java > tests/java/com/twitter/common/net/http/RequestLoggerTest.java > tests/java/com/twitter/common/net/InetSocketAddressHelperTest.java > tests/java/com/twitter/common/net/loadbalancing/LeastConnectedStrategyTest.java > tests/java/com/twitter/common/net/loadbalancing/LoadBalancerImplTest.java > tests/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyTest.java > tests/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyWithHostCheckTest.java > tests/java/com/twitter/common/net/loadbalancing/RandomStrategyTest.java > tests/java/com/twitter/common/net/loadbalancing/RoundRobinStrategyTest.java > tests/java/com/twitter/common/net/loadbalancing/SubsetStrategyTest.java > tests/java/com/twitter/common/net/monitoring/TrafficMonitorTest.java > tests/java/com/twitter/common/net/pool/ConnectionPoolTest.java > tests/java/com/twitter/common/net/pool/DynamicHostSetUtilTest.java > tests/java/com/twitter/common/net/pool/DynamicPoolTest.java > tests/java/com/twitter/common/net/UrlHelperTest.java > tests/java/com/twitter/common/net/UrlResolverTest.java > tests/java/com/twitter/common/net/UrlResolverUtilTest.java > tests/java/com/twitter/common/net/UrlTokenizerUtilTest.java > tests/java/com/twitter/common/objectsize/ObjectSizeCalculatorTest.java > tests/java/com/twitter/common/quantity/AmountTest.java > tests/java/com/twitter/common/stats/ApproximateHistogramTest.java > tests/java/com/twitter/common/stats/ElapsedTest.java > tests/java/com/twitter/common/stats/EntropyTest.java > tests/java/com/twitter/common/stats/MergedHistogramTest.java > tests/java/com/twitter/common/stats/MovingAverageTest.java > tests/java/com/twitter/common/stats/MovingWindowDeltaTest.java > tests/java/com/twitter/common/stats/NumericStatExporterTest.java > tests/java/com/twitter/common/stats/PercentileTest.java > tests/java/com/twitter/common/stats/PipelineStatsTest.java > tests/java/com/twitter/common/stats/PrintableHistogramTest.java > tests/java/com/twitter/common/stats/RateTest.java > tests/java/com/twitter/common/stats/ReservoirSamplerTest.java > tests/java/com/twitter/common/stats/StatisticsTest.java > tests/java/com/twitter/common/stats/StatsTest.java > tests/java/com/twitter/common/stats/TimeSeriesRepositoryImplTest.java > tests/java/com/twitter/common/stats/WindowedHistogramTest.java > tests/java/com/twitter/common/stats/WindowedStatsTest.java > tests/java/com/twitter/common/stats/WindowedTest.java > tests/java/com/twitter/common/testing/easymock/EasyMockTestTest.java > tests/java/com/twitter/common/testing/easymock/IterableEqualsTest.java > tests/java/com/twitter/common/testing/junit/rules/RetryTest.java > tests/java/com/twitter/common/testing/TearDownRegistryTest.java > tests/java/com/twitter/common/thrift/callers/AbstractCallerTest.java > tests/java/com/twitter/common/thrift/callers/DeadlineCallerTest.java > tests/java/com/twitter/common/thrift/callers/RetryingCallerTest.java > tests/java/com/twitter/common/thrift/ThriftConnectionFactoryTest.java > tests/java/com/twitter/common/thrift/ThriftFactoryTest.java > tests/java/com/twitter/common/thrift/ThriftTest.java > tests/java/com/twitter/common/util/BackoffDeciderTest.java > tests/java/com/twitter/common/util/BackoffHelperTest.java > tests/java/com/twitter/common/util/caching/CachingMethodProxyTest.java > tests/java/com/twitter/common/util/caching/LRUCacheTest.java > tests/java/com/twitter/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java > tests/java/com/twitter/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java > tests/java/com/twitter/common/util/LowResClockTest.java > tests/java/com/twitter/common/util/QueueDrainerTest.java > tests/java/com/twitter/common/util/RateLimitedCommandExecutorTest.java > tests/java/com/twitter/common/util/SamplerTest.java > tests/java/com/twitter/common/util/StateMachineTest.java > tests/java/com/twitter/common/util/templating/StringTemplateHelperTest.java > tests/java/com/twitter/common/util/testing/FakeClockTest.java > tests/java/com/twitter/common/util/TruncatedBinaryBackoffTest.java > tests/java/com/twitter/common/zookeeper/CandidateImplTest.java > tests/java/com/twitter/common/zookeeper/CompoundServerSetTest.java > tests/java/com/twitter/common/zookeeper/DistributedLockTest.java > tests/java/com/twitter/common/zookeeper/GroupTest.java > tests/java/com/twitter/common/zookeeper/guice/ServerSetModuleTest.java > tests/java/com/twitter/common/zookeeper/PartitionerTest.java > tests/java/com/twitter/common/zookeeper/ServerSetImplTest.java > tests/java/com/twitter/common/zookeeper/ServerSetsTest.java > tests/java/com/twitter/common/zookeeper/SingletonServiceTest.java > tests/java/com/twitter/common/zookeeper/StaticServerSetTest.java > tests/java/com/twitter/common/zookeeper/ZooKeeperClientTest.java > tests/java/com/twitter/common/zookeeper/ZooKeeperMapTest.java > tests/java/com/twitter/common/zookeeper/ZooKeeperNodeTest.java > tests/java/com/twitter/common/zookeeper/ZooKeeperUtilsTest.java > tests/resources/com/twitter/common/util/templating/template.st > ```` > > The majority of the code was placed under a 'commons' subproject so it does not > need to share the same checkstyle configuration as the main aurora code. Since > pants is capable of compiling annotation processors related code concurrently and > gradle is not, the CmdLineProcessor annotation processor and related > dependencies were moved into its own gradle project called 'commons-args'. > > In order for this import to compile and have tests pass a few minor changes were > done to the source files. The first set of changes were done to deal with the > thrift version incompatibility between Twitter Commons and Aurora. Twitter > Commons depended on thrift 0.5.0 and Aurora currently depends on thrift 0.9.0. > There was a source incompatible API chance in > org.apache.thrift.async.AsyncMethodCallback interface and the following files > had minor changes made so the code would compile: > > ```` > commons/src/main/java/com/twitter/common/thrift/callers/Caller.java > commons/src/main/java/com/twitter/common/thrift/callers/CallerDecorator.java > commons/src/main/java/com/twitter/common/thrift/callers/RetryingCaller.java > commons/src/main/java/com/twitter/common/thrift/callers/ThriftCaller.java > commons/src/test/java/com/twitter/common/thrift/ThriftFactoryTest.java > commons/src/test/java/com/twitter/common/thrift/ThriftTest.java > ```` > > These classes are not used in Aurora directly but are instead used in the > testing of com.twitter.common.zookeeper components so the nature of the changes > do not need to be reviewed. > > The second set of changes involves removing use of junit annotations. Three > files used junit annotaions from twitter common (`@TestParallel` and > `@TestSerial`) that are not available in tree but instead as another dependency. > To prevent adding another dependency to the build the following files were > modified to remove use of the annotations. > > ```` > commons/src/test/java/com/twitter/common/stats/ApproximateHistogramTest.java > commons/src/test/java/com/twitter/common/stats/WindowedStatsTest.java > commons/src/test/java/com/twitter/common/testing/junit/rules/RetryTest.java > ```` > > The third change involves adding the META-INF resource file for the > CmdLineProcessor annotation processor: > `commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor`. > This annotation is necessary for javac to discover the annotation processor and > invoke it. The pants build tool automatically generated this file but gradle > does not. > > The final change involves ignoring a single failing test: > `com.twitter.common.zookeeper.ServerSetImplTest#testJsonCodecCompatibility`. > This test fails with thrift 0.9.0 due to internal thrift changes. A TODO was > added to fix it later. > > > Diffs > ----- > > .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb > build.gradle 57fec4edd082883c4a71ebe418f1aa6f8ddaa878 > commons-args/src/main/java/com/twitter/common/args/Arg.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/ArgParser.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/CmdLine.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/NoParser.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/Parser.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/ParserOracle.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/Positional.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/Verifier.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/VerifierFor.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/apt/CmdLineProcessor.java PRE-CREATION > commons-args/src/main/java/com/twitter/common/args/apt/Configuration.java PRE-CREATION > commons-args/src/main/resources/META-INF/services/javax.annotation.processing.Processor PRE-CREATION > commons/src/main/java/com/twitter/common/application/AbstractApplication.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/AppLauncher.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/Application.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/Lifecycle.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/ShutdownRegistry.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/ShutdownStage.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/StartupRegistry.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/StartupStage.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/DefaultQuitHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/GraphViewer.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/HttpAssetConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/HttpFilterConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/HttpServletConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/http/Registration.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/AppLauncherModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/LifecycleModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/LocalServiceRegistry.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/LogModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/StatsExportModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/StatsModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/application/modules/ThriftModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/ArgFilters.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/ArgScanner.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/Args.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/ArgumentInfo.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/OptionInfo.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/Parsers.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/PositionalInfo.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/TypeUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/Verifiers.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanExecute.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanExecuteFileVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanRead.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanReadFileVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanWrite.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/CanWriteFileVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/Exists.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/ExistsFileVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/IsDirectory.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/IsDirectoryFileVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotEmpty.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotEmptyIterableVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotEmptyStringVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotNegative.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotNegativeNumberVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotNull.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/NotNullVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/Positive.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/PositiveNumberVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/Range.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/constraints/RangeNumberVerifier.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/AmountParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/BooleanParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/ByteParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/CharacterParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/ClassParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/DateParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/DoubleParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/DurationParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/EnumParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/FileParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/FloatParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/InetSocketAddressParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/IntegerParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/ListParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/LongParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/MapParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/NonParameterizedTypeParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/NumberParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/PairParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/PatternParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/RangeParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/SetParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/ShortParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/StringParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/TypeParameterizedParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/URIParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/URLParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/args/parsers/UnitParser.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/CachingSupplier.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/CallableExceptionalSupplier.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Closure.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Closures.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Command.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Commands.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Either.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionTransporter.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionalClosure.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionalCommand.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionalFunction.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionalFunctions.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/ExceptionalSupplier.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Function.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/MorePreconditions.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/MoreSuppliers.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/Supplier.java PRE-CREATION > commons/src/main/java/com/twitter/common/base/SupplierE.java PRE-CREATION > commons/src/main/java/com/twitter/common/collections/Bits.java PRE-CREATION > commons/src/main/java/com/twitter/common/collections/BoundedQueue.java PRE-CREATION > commons/src/main/java/com/twitter/common/collections/Iterables2.java PRE-CREATION > commons/src/main/java/com/twitter/common/collections/Multimaps.java PRE-CREATION > commons/src/main/java/com/twitter/common/collections/Pair.java PRE-CREATION > commons/src/main/java/com/twitter/common/inject/Bindings.java PRE-CREATION > commons/src/main/java/com/twitter/common/inject/DefaultProvider.java PRE-CREATION > commons/src/main/java/com/twitter/common/inject/ProviderMethodModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/inject/TimedInterceptor.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/Base64ZlibCodec.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/Codec.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/CompatibilityCodec.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/FileUtils.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/JsonCodec.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/Streamer.java PRE-CREATION > commons/src/main/java/com/twitter/common/io/ThriftCodec.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/BufferedLog.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/Glog.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/Log.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/LogFormatter.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/LogUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/RootLogConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/julbridge/JULBridgeHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/julbridge/JULBridgeLevelConverter.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/julbridge/JULBridgeLogManager.java PRE-CREATION > commons/src/main/java/com/twitter/common/logging/log4j/GlogLayout.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/Environment.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/InetSocketAddressHelper.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/ProxyAuthorizer.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/ProxyConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/UrlHelper.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/UrlResolver.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/UrlResolverUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/UrlTokenizerUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/GuiceServletConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/HttpServerDispatch.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/JettyHttpServerDispatch.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/RequestLogger.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/filters/AbstractHttpFilter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/filters/HttpStatsFilter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/AbortHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/AssetHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/ContentionPrinter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/HealthHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/HttpServletRequestParams.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/LogConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/LogPrinter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/QuitHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/StringTemplateServlet.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/TextResponseHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/ThreadStackPrinter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/ThriftServlet.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/TimeSeriesDataSource.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/VarsHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/http/handlers/VarsJsonHandler.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/LeastConnectedStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/LoadBalancer.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/LoadBalancerImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/LoadBalancingStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/MarkDeadStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyWithHostCheck.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/RandomStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/RequestTracker.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/RoundRobinStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/StaticLoadBalancingStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/SubsetStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/loadbalancing/TrafficMonitorAdapter.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/monitoring/ConnectionMonitor.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/monitoring/TrafficMonitor.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/Connection.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/ConnectionFactory.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/ConnectionPool.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/DynamicHostSet.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/DynamicHostSetUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/DynamicPool.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/MetaPool.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/ObjectPool.java PRE-CREATION > commons/src/main/java/com/twitter/common/net/pool/ResourceExhaustedException.java PRE-CREATION > commons/src/main/java/com/twitter/common/objectsize/ObjectSizeCalculator.java PRE-CREATION > commons/src/main/java/com/twitter/common/quantity/Amount.java PRE-CREATION > commons/src/main/java/com/twitter/common/quantity/Data.java PRE-CREATION > commons/src/main/java/com/twitter/common/quantity/Time.java PRE-CREATION > commons/src/main/java/com/twitter/common/quantity/Unit.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/ApproximateHistogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/CounterMap.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/CounterMapWithTopKey.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Elapsed.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Entropy.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Histogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Histograms.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/JvmStats.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/MovingAverage.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/MovingWindowDelta.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/NumericStatExporter.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Percentile.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/PipelineStats.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Precision.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/PrintableHistogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Rate.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Ratio.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/RecordingStat.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/RecordingStatImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/RequestStats.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/ReservoirSampler.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/SampledStat.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Significance.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/SlidingStats.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Stat.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/StatImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/StatRegistry.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Statistics.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/StatisticsInterface.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Stats.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/StatsProvider.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/TimeSeries.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/TimeSeriesRepository.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/TimeSeriesRepositoryImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/Windowed.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/WindowedApproxHistogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/WindowedHistogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/WindowedStatistics.java PRE-CREATION > commons/src/main/java/com/twitter/common/stats/testing/RealHistogram.java PRE-CREATION > commons/src/main/java/com/twitter/common/testing/TearDownRegistry.java PRE-CREATION > commons/src/main/java/com/twitter/common/testing/easymock/EasyMockTest.java PRE-CREATION > commons/src/main/java/com/twitter/common/testing/easymock/IterableEquals.java PRE-CREATION > commons/src/main/java/com/twitter/common/testing/junit/rules/Retry.java PRE-CREATION > commons/src/main/java/com/twitter/common/testing/mockito/MockitoTest.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/Config.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/TResourceExhaustedException.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/TTimeoutException.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/TTransportConnection.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/Thrift.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/ThriftConnectionFactory.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/ThriftException.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/ThriftFactory.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/Util.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/Caller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/CallerDecorator.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/DeadlineCaller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/DebugCaller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/RetryingCaller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/StatTrackingCaller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/callers/ThriftCaller.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/monitoring/TMonitoredNonblockingServerSocket.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/monitoring/TMonitoredProcessor.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/monitoring/TMonitoredServerSocket.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/testing/MockTSocket.java PRE-CREATION > commons/src/main/java/com/twitter/common/thrift/testing/TestThriftTypes.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/BackoffDecider.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/BackoffHelper.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/BackoffStrategy.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/BuildInfo.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/Clock.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/CommandExecutor.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/DateUtils.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/FileUtils.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/LowResClock.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/ParsingUtil.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/QueueDrainer.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/Random.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/RangeNormalizer.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/RateLimitedCommandExecutor.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/RetryingRunnable.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/Sampler.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/StartWatch.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/Stat.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/StateMachine.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/Timer.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/TruncatedBinaryBackoff.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/caching/Cache.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/caching/CachingMethodProxy.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/caching/LRUCache.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/BackingOffFutureTask.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/ExceptionHandlingExecutorService.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/ExceptionHandlingScheduledExecutorService.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/ExecutorServiceShutdown.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/ForwardingExecutorService.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/MoreExecutors.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/RetryingFutureTask.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/concurrent/TaskConverter.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/logging/ResourceLoggingConfigurator.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/logging/UnresettableLogManager.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/templating/StringTemplateHelper.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/testing/FakeClock.java PRE-CREATION > commons/src/main/java/com/twitter/common/util/testing/FakeTicker.java PRE-CREATION > commons/src/main/java/com/twitter/common/webassets/bootstrap/BootstrapModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/webassets/jquery/JQueryModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/Candidate.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/CandidateImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/CompoundServerSet.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/DistributedLock.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/DistributedLockImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/Group.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/Partitioner.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ServerSet.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ServerSetImpl.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ServerSets.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/SingletonService.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/StaticServerSet.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ZooKeeperClient.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ZooKeeperMap.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ZooKeeperNode.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/ZooKeeperUtils.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/guice/ServerSetModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/guice/client/ZooKeeperClientModule.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/guice/client/flagged/FlaggedClientConfig.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/testing/BaseZooKeeperTest.java PRE-CREATION > commons/src/main/java/com/twitter/common/zookeeper/testing/ZooKeeperTestServer.java PRE-CREATION > commons/src/main/resources/com/twitter/common/application/http/graphview/dygraph-combined.js PRE-CREATION > commons/src/main/resources/com/twitter/common/application/http/graphview/dygraph-extra.js PRE-CREATION > commons/src/main/resources/com/twitter/common/application/http/graphview/grapher.js PRE-CREATION > commons/src/main/resources/com/twitter/common/application/http/graphview/graphview.html PRE-CREATION > commons/src/main/resources/com/twitter/common/application/http/graphview/parser.js PRE-CREATION > commons/src/main/resources/com/twitter/common/net/http/handlers/logconfig.st PRE-CREATION > commons/src/main/resources/com/twitter/common/net/http/handlers/logprinter.st PRE-CREATION > commons/src/main/resources/com/twitter/common/net/http/handlers/thrift.st PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.1.1/css/bootstrap-responsive.min.css PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.1.1/css/bootstrap.min.css PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings-white.png PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.1.1/img/glyphicons-halflings.png PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.1.1/js/bootstrap.min.js PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.3.2/css/bootstrap-responsive.min.css PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.3.2/css/bootstrap.min.css PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings-white.png PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.3.2/img/glyphicons-halflings.png PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/bootstrap/2.3.2/js/bootstrap.min.js PRE-CREATION > commons/src/main/resources/com/twitter/common/webassets/jquery/js/jquery-1.8.2.min.js PRE-CREATION > commons/src/main/thrift/com/twitter/thrift/endpoint.thrift PRE-CREATION > commons/src/test/java/com/twitter/common/application/AppLauncherTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/application/modules/LifecycleModuleTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/application/modules/LocalServiceRegistryTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/application/modules/StartStatPollerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/ArgFiltersTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/ArgScannerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/ArgTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/ArgsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/OptionInfoTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/ParsersTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/argfilterstest/ArgsRoot.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/argfilterstest/subpackageA/ArgsA.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/argfilterstest/subpackageA/subsubpackage1/ArgsA1.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/argfilterstest/subpackageB/ArgsB.java PRE-CREATION > commons/src/test/java/com/twitter/common/args/argfilterstest/subpackageBwithSuffix/ArgsBWithSuffix.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/CachingSupplierTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/ClosuresTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/CommandsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/EitherTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/ExceptionTransporterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/ExceptionalFunctionsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/MorePreconditionsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/base/MoreSuppliersTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/collections/BitsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/collections/BoundedQueueTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/collections/Iterables2Test.java PRE-CREATION > commons/src/test/java/com/twitter/common/collections/PairTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/inject/BindingsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/inject/DefaultProviderTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/Base64ZlibCodecTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/CodecTestUtilities.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/CompatibilityCodecTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/FileUtilsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/JsonCodecTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/io/ThriftCodecTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/BufferedLogTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/LogFormatterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/LogUtilTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/RootLogConfigTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/julbridge/JULBridgeHandlerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/julbridge/JULBridgeLevelConverterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/logging/julbridge/JULBridgeLogManagerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/InetSocketAddressHelperTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/UrlHelperTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/UrlResolverTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/UrlResolverUtilTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/UrlTokenizerUtilTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/RequestLoggerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/filters/HttpStatsFilterIntegrationTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/filters/HttpStatsFilterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/AssetHandlerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/HttpServletRequestParamsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/LogPrinterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/StatSupplierTestBase.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/TimeSeriesDataSourceTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/VarsHandlerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/http/handlers/VarsJsonHandlerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/LeastConnectedStrategyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/LoadBalancerImplTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/MarkDeadStrategyWithHostCheckTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/RandomStrategyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/RoundRobinStrategyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/loadbalancing/SubsetStrategyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/monitoring/TrafficMonitorTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/pool/ConnectionPoolTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/pool/DynamicHostSetUtilTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/net/pool/DynamicPoolTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/objectsize/ObjectSizeCalculatorTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/quantity/AmountTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/ApproximateHistogramTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/ElapsedTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/EntropyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/MergedHistogramTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/MovingAverageTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/MovingWindowDeltaTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/NumericStatExporterTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/PercentileTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/PipelineStatsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/PrintableHistogramTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/RateTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/ReservoirSamplerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/StatisticsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/StatsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/TimeSeriesRepositoryImplTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/WindowedHistogramTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/WindowedStatsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/stats/WindowedTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/testing/TearDownRegistryTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/testing/easymock/EasyMockTestTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/testing/easymock/IterableEqualsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/testing/junit/rules/RetryTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/ThriftConnectionFactoryTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/ThriftFactoryTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/ThriftTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/callers/AbstractCallerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/callers/DeadlineCallerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/thrift/callers/RetryingCallerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/BackoffDeciderTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/BackoffHelperTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/LowResClockTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/QueueDrainerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/RateLimitedCommandExecutorTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/SamplerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/StateMachineTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/TruncatedBinaryBackoffTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/caching/CachingMethodProxyTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/caching/LRUCacheTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/concurrent/ExceptionHandlingExecutorServiceTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/concurrent/ExceptionHandlingScheduledExecutorServiceTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/templating/StringTemplateHelperTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/util/testing/FakeClockTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/CandidateImplTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/CompoundServerSetTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/DistributedLockTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/GroupTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/PartitionerTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ServerSetImplTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ServerSetsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/SingletonServiceTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/StaticServerSetTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ZooKeeperClientTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ZooKeeperMapTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ZooKeeperNodeTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/ZooKeeperUtilsTest.java PRE-CREATION > commons/src/test/java/com/twitter/common/zookeeper/guice/ServerSetModuleTest.java PRE-CREATION > commons/src/test/resources/com/twitter/common/util/templating/template.st PRE-CREATION > settings.gradle 6180227b91f62df67cc5a53f04d8a699a7967f81 > src/main/java/org/apache/aurora/scheduler/Resources.java 3b4fbb6c625061b0c3afa57482a7ba99a9c6ced5 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8162323816aedc711a3af84cd499250b78718ab3 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java a0e71e1c74f67b8836e7da5418012f342977f661 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 74a654619b56301c8745eac47cfb9d38b9d7de66 > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 6dbc5d6c052f59a0d326ecfe33a92669d4b38e13 > src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 39c055da8f2552bd11705f7f1e147ffc98b99f7c > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 66f20c6a63b331353c467cde5521f21e4df49e2d > src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java b6623d5e1160e97af397b1a54da3f5d4304dcceb > > Diff: https://reviews.apache.org/r/37666/diff/ > > > Testing > ------- > > ./gradlew clean build > e2e tests pass > > > Thanks, > > Zameer Manji > > --===============4014127990072352492==--