Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8363710BFC for ; Tue, 18 Aug 2015 18:23:05 +0000 (UTC) Received: (qmail 52566 invoked by uid 500); 18 Aug 2015 18:23:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 52518 invoked by uid 500); 18 Aug 2015 18:23:05 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 52483 invoked by uid 99); 18 Aug 2015 18:23:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2015 18:23:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0DD59D5313; Tue, 18 Aug 2015 18:23:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4078925689453243485==" MIME-Version: 1.0 Subject: Re: Review Request 37560: Adding TierManager initial implementation. From: "Maxim Khutornenko" To: "Joshua Cohen" , "Zameer Manji" Cc: "Aurora" , "Aurora ReviewBot" , "Stephan Erb" , "Maxim Khutornenko" Date: Tue, 18 Aug 2015 18:23:05 -0000 Message-ID: <20150818182305.19713.47584@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37560/ X-Sender: "Maxim Khutornenko" References: <20150818170439.1534.38602@reviews.apache.org> In-Reply-To: <20150818170439.1534.38602@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora --===============4078925689453243485== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37560/ ----------------------------------------------------------- (Updated Aug. 18, 2015, 6:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes ------- Fixing visibility and adding coverage. Bugs: AURORA-1437 https://issues.apache.org/jira/browse/AURORA-1437 Repository: aurora Description ------- Introducing `TierManager` implementation. This diff addresses basic needs within the Oversubscription feature scope. Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately. More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560 src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163 src/test/java/org/apache/aurora/scheduler/ResourcesTest.java a5878a4efada5b5872be77ad887a0ffe8695d6b8 src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b Diff: https://reviews.apache.org/r/37560/diff/ Testing ------- ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko --===============4078925689453243485==--