Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5711718A1B for ; Fri, 14 Aug 2015 15:54:35 +0000 (UTC) Received: (qmail 63570 invoked by uid 500); 14 Aug 2015 15:54:35 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 63520 invoked by uid 500); 14 Aug 2015 15:54:35 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 63500 invoked by uid 99); 14 Aug 2015 15:54:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2015 15:54:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 36C9EDD6F8; Fri, 14 Aug 2015 15:54:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7807806133485657485==" MIME-Version: 1.0 Subject: Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id. From: "David McLaughlin" To: "Maxim Khutornenko" , "David McLaughlin" Cc: "Joshua Cohen" , "Aurora" Date: Fri, 14 Aug 2015 15:54:32 -0000 Message-ID: <20150814155432.30461.51471@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37365/ X-Sender: "David McLaughlin" References: <20150814144444.1374.96648@reviews.apache.org> In-Reply-To: <20150814144444.1374.96648@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora --===============7807806133485657485== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95427 ----------------------------------------------------------- src/main/resources/scheduler/assets/js/app.js (lines 35 - 38) I feel like changing our URLs like this needs a deprecation path. This would break tooling around Aurora that assumes how to construct update URLs, as seen by the fix you had to apply to the client code. src/main/resources/scheduler/assets/js/controllers.js (line 521) You can just do BaseJobController($scope, ...) now? Here and in other invocations. - David McLaughlin On Aug. 14, 2015, 2:44 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37365/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 2:44 p.m.) > > > Review request for Aurora, David McLaughlin and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Add a new UI page to show all tasks (active and completed) for a specific instance id. > > N.B.: changes to controllers.js look significant, but it's 90% refactoring so that JobController and JobInstanceController can reuse common code. > > > Diffs > ----- > > src/main/python/apache/aurora/client/base.py dee4c28a26828912bec073c7e5213a03c9703eee > src/main/resources/scheduler/assets/breadcrumb.html 13147935c3c28680d5decd1e03e40d9cf04aaed3 > src/main/resources/scheduler/assets/css/app.css a4735efe58a09a46f2b95ebe98f219cb9e7ee27d > src/main/resources/scheduler/assets/instance.html PRE-CREATION > src/main/resources/scheduler/assets/job.html 942635a61132bb9a38a6faf3f8fe046e6bcabd95 > src/main/resources/scheduler/assets/js/app.js b66409f628046c67b62c92a75cbeed20c09b4ec1 > src/main/resources/scheduler/assets/js/controllers.js 04ea1cb6998af7c238eb2fd1a7d05a9663abc56c > src/main/resources/scheduler/assets/js/services.js a514fa7da3c049e1f5a3e49263a82cf2c28d1b2d > src/main/resources/scheduler/assets/taskInstance.html PRE-CREATION > src/test/python/apache/aurora/client/cli/test_supdate.py 21bea702a6e6fe68652e2195c5d24b56b6477738 > src/test/python/apache/aurora/client/test_base.py 1a560088279ac945cce14d02454e50b8483771e4 > > Diff: https://reviews.apache.org/r/37365/diff/ > > > Testing > ------- > > - ./gradlew jsHint > - ./pants test src/test/python/apache/aurora/client:base > - Verified update page url in client was correct in Vagrant. > - See attached screenshot for an example of what the instance page looks like. > > > File Attachments > ---------------- > > Example of instance page in action. > https://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png > > > Thanks, > > Joshua Cohen > > --===============7807806133485657485==--