Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A85F518705 for ; Mon, 10 Aug 2015 18:25:20 +0000 (UTC) Received: (qmail 73933 invoked by uid 500); 10 Aug 2015 18:25:09 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 73882 invoked by uid 500); 10 Aug 2015 18:25:09 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 73859 invoked by uid 99); 10 Aug 2015 18:25:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Aug 2015 18:25:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F069ADA8BD; Mon, 10 Aug 2015 18:25:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4749496356084475024==" MIME-Version: 1.0 Subject: Re: Review Request 37141: DbStorage: avoid flushing for reentrant writes, remove extra @Transactional. From: "Maxim Khutornenko" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora" Date: Mon, 10 Aug 2015 18:25:06 -0000 Message-ID: <20150810182506.1374.2803@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37141/ X-Sender: "Maxim Khutornenko" References: <20150807133509.11538.93013@reviews.apache.org> In-Reply-To: <20150807133509.11538.93013@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora --===============4749496356084475024== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/#review94773 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On Aug. 7, 2015, 1:35 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37141/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 1:35 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1395 > https://issues.apache.org/jira/browse/AURORA-1395 > > > Repository: aurora > > > Description > ------- > > Two loose ends from r/37049: > - An extra @Transactional which rendered the inner transaction useless, and results in async work still being performed within the transaction. > - No handling for reentrant calls to write(), causing async work to be flushed in inner calls and before the transaction actually completes. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java aac62e2bbc212f61e61ffca75753ef06f1701ea4 > src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 3b05db9481edc7a82c0823cf50793c7d12384541 > > Diff: https://reviews.apache.org/r/37141/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============4749496356084475024==--