Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C301418CD4 for ; Fri, 7 Aug 2015 13:21:49 +0000 (UTC) Received: (qmail 24161 invoked by uid 500); 7 Aug 2015 13:21:49 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 24114 invoked by uid 500); 7 Aug 2015 13:21:49 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 24095 invoked by uid 99); 7 Aug 2015 13:21:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Aug 2015 13:21:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 17695DA62C; Fri, 7 Aug 2015 13:21:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5149954657621045604==" MIME-Version: 1.0 Subject: Re: Review Request 37215: Use the system-wide AsyncExecutor for pubsub events. From: "Aurora ReviewBot" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Fri, 07 Aug 2015 13:21:47 -0000 Message-ID: <20150807132147.11538.26545@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37215/ X-Sender: "Aurora ReviewBot" References: <20150807125204.11538.62561@reviews.apache.org> In-Reply-To: <20150807125204.11538.62561@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============5149954657621045604== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37215/#review94535 ----------------------------------------------------------- Ship it! Master (8adc9bd) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 7, 2015, 12:52 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37215/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 12:52 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1395 > https://issues.apache.org/jira/browse/AURORA-1395 > > > Repository: aurora > > > Description > ------- > > This should be the final missing piece for proper deferment of async work created in the scope of a transaction. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9 > src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4 > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 350ec6f3c6aa0526b484758a64165392c87842c4 > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52 > > Diff: https://reviews.apache.org/r/37215/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============5149954657621045604==--