Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FAE2182DE for ; Tue, 4 Aug 2015 18:05:03 +0000 (UTC) Received: (qmail 71875 invoked by uid 500); 4 Aug 2015 18:05:03 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 71824 invoked by uid 500); 4 Aug 2015 18:05:03 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 71803 invoked by uid 99); 4 Aug 2015 18:05:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 18:05:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E8536D90B8; Tue, 4 Aug 2015 18:05:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1103211771236200984==" MIME-Version: 1.0 Subject: Re: Review Request 37087: Add all Docker options supported by Mesos From: "Aurora ReviewBot" To: "Bill Farner" , "Jake Farrell" Cc: "Aurora ReviewBot" , "Dan Norris" , "Aurora" Date: Tue, 04 Aug 2015 18:05:00 -0000 Message-ID: <20150804180500.17264.36754@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37087/ X-Sender: "Aurora ReviewBot" References: <20150804175242.17264.12346@reviews.apache.org> In-Reply-To: <20150804175242.17264.12346@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============1103211771236200984== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37087/#review94095 ----------------------------------------------------------- Ship it! Master (7fdcfef) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 4, 2015, 5:52 p.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37087/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 5:52 p.m.) > > > Review request for Aurora, Jake Farrell and Bill Farner. > > > Bugs: AURORA-1396 > https://issues.apache.org/jira/browse/AURORA-1396 > > > Repository: aurora > > > Description > ------- > > Add all Docker options supported by Mesos. > > Specifically, this enables you to pass the following options to a Docker object: > - Docker networking modes > - Privileged mode > - Force pull images > - Docker port mapptings > > This also updates the ordering in the Docker struct in Thrift to match the Mesos protobuf message. > > Tickets covered: AURORA-1396, AURORA-1057, AURORA-1095. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift f792be0ad393072b4a4ec525363e06cfd16b63d0 > docs/configuration-reference.md ad2701cadd38bb2fdbbe2acc477038986f8ec733 > examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 1903315c0753c68fd1e103d48fff037ba59b7642 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 27f1f33ffc782b3d2a2a9add494c04911659e217 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java afb66c5f79c08c966807c403b334e8589126f2fe > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/DockerNetworkingModeTypeHandler.java PRE-CREATION > src/main/python/apache/aurora/config/schema/base.py 214d5594a2c22e92d5412e40c2ddf18e65c2af63 > src/main/python/apache/aurora/config/thrift.py adf53bb1c28d61e9bcb670c60f293cf8262c5836 > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bfad339a84c6ca87bc6fea339af10a559d8eb3d5 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 7634047abaec9129ee9ead08cc51a10b3261515d > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java fc44389ee07de3dba258d04c65c5bfff13e4eef9 > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java b231827ff7fdb2aa37580a32cae74d5da17c2f97 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441 > src/test/python/apache/aurora/config/test_thrift.py 061864eb475807332d328fa72f35f179d36ef9e8 > > Diff: https://reviews.apache.org/r/37087/diff/ > > > Testing > ------- > > Ran build-support/jenkins/build.sh and the e2e tests in Vagrant. > > > Thanks, > > Dan Norris > > --===============1103211771236200984==--