aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 37964: Allow for slashes in metric names
Date Mon, 31 Aug 2015 23:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37964/#review97189
-----------------------------------------------------------

Ship it!


Master (89da936) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 31, 2015, 9:34 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37964/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 9:34 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1282
>     https://issues.apache.org/jira/browse/AURORA-1282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow for slashes in metric names
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java f2bd05d4739f5d0f07fae33ac6e7b32d12ce574d

>   commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 91bbc096748952cc7dbf0cbd83a2d95456e0ce0a

> 
> Diff: https://reviews.apache.org/r/37964/diff/
> 
> 
> Testing
> -------
> 
> ```
> [tw-mbp-jsmith aurora (stats-slashes)]$ ./gradlew build -Pq
> # snip
> 
> BUILD SUCCESSFUL
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message