aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 37937: Remove barely used commons classes.
Date Mon, 31 Aug 2015 04:34:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37937/#review97054
-----------------------------------------------------------


Master (68447b3) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 31, 2015, 4:20 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37937/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 4:20 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch removes a few barely used or duplicate classes from commons.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 2e22a9244cabe2547149074efbf68ac23902fdf8

>   commons/src/main/java/org/apache/aurora/common/base/ExceptionalFunction.java f867c350eb7df330fc5913605a0a8099b13cf78c

>   commons/src/main/java/org/apache/aurora/common/base/Function.java d089eb8c3b1eb6ad1617606309624be1fa8bdd5b

>   commons/src/main/java/org/apache/aurora/common/base/MoreSuppliers.java 9ab877d63937a9e8a2741ef30acbd69362c9815b

>   commons/src/main/java/org/apache/aurora/common/base/Supplier.java cb6e86a9ef1b9450a9cde9a252b9b1be1dd6eac5

>   commons/src/main/java/org/apache/aurora/common/io/FileUtils.java 348e85918dc0c6de5fb517e22b24dd8d0b940e32

>   commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
9d9fb9bff09511eade9d8556dda3327ff191ae0d 
>   commons/src/main/java/org/apache/aurora/common/testing/junit/rules/Retry.java 3b97118c2cef8d34a5aa4579e7f4b01f221e400b

>   commons/src/main/java/org/apache/aurora/common/util/StartWatch.java 4d19ed637cf62bd71296e687549d3dfaa3f6f312

>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java cb0f3ec2b8850dea0758c5a209da022778657e71

>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 18aff9f04f073f6f2860d9c5040bec0a5fec6215

>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
db9e5ca532c0a7fd07ee60cfd79b54c5e2d59353 
>   commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java dc83f7445721ac941affdd9a9895bbc2f1750fb9

>   commons/src/test/java/org/apache/aurora/common/base/MoreSuppliersTest.java a655f597c7e787a1ef25d0463028387521733950

>   commons/src/test/java/org/apache/aurora/common/io/FileUtilsTest.java a043451cf12ebbf57b8ed7832b77916b0b81a8c2

>   commons/src/test/java/org/apache/aurora/common/stats/RateTest.java 15bd65bafd1cee9a30825f102195fb962471c357

>   commons/src/test/java/org/apache/aurora/common/testing/junit/rules/RetryTest.java 43be9dfcea8dba237e3ab12222ca8d4a67c2cccd

>   commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java 6bf71cfd52d51eeee471844d52f90ffcc792bd57

>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 09d9016b7aa8dc5c6ee5b4363107cb75a63722bf

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 67788223bc6ef4a9c1837ce636160c191cd86a74

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 0c59b2dbeaf32964e21b5e837ea95b8a9789a0de

>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 05af127a91b6c0e8db089cb828c38e556b07d45f

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 906f3e622b8cd30e21d51c1fa7aa16e97ddd6443

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java ed639b6c20a3a51aa829cacb8e5b30265600c9cd

>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java cc74d978e5cd74f5be9e2cd54cda693d6f56d9bc

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 6ac0696f0bec46efec263be2ee13ce76df85dd3e

> 
> Diff: https://reviews.apache.org/r/37937/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message