aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files
Date Sat, 29 Aug 2015 10:22:34 GMT


> On Aug. 26, 2015, 7:55 p.m., Zameer Manji wrote:
> > The ticket referenced also talks about {{mesos.ip}}, will you also add support for
that?
> 
> Steve Niemitz wrote:
>     It's not exposed anywhere by mesos AFAIK.  If someone can correct me I can add it
in another review.

I have to agree, looks like Mesos does not export it [1]. I think this review is therefore
ready to go. I will update my original ticket to drop the need for ip. We can implement that
on our own within the container once the hostname has been exposed.

[1] https://github.com/apache/mesos/blob/8a01dd8d2a6517d2fcf2983a436c5ce37e3666bf/include/mesos/mesos.proto#L848.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96565
-----------------------------------------------------------


On Aug. 28, 2015, 12:48 a.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 12:48 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1261
>     https://issues.apache.org/jira/browse/AURORA-1261
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added support for {{mesos.hostname}} in aur files
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c

>   src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558

>   src/main/python/apache/aurora/executor/common/task_info.py 082947548d8d8e0eaf2ee4807636f50237e0ce22

>   src/test/python/apache/aurora/config/test_base.py 5a58dd0f072889a850153841f972dcca4d3c913b

>   src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31

> 
> Diff: https://reviews.apache.org/r/37801/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message