aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Review Request 37859: Rename slave to agent in src/main/python.
Date Thu, 27 Aug 2015 22:11:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37859/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Zameer Manji.


Bugs: AURORA-1454 and AURORA-1455
    https://issues.apache.org/jira/browse/AURORA-1454
    https://issues.apache.org/jira/browse/AURORA-1455


Repository: aurora


Description
-------

Use "Mesos Agent" instead of "Mesos Slave" in src/main/python.

This changes the name in all places where the Python code controls the use of the name (comments,
pydoc, private variable names). It doesn't change the reference in places it doesn't control
(`clusters.json`, `api.thrift`, `mesos.proto`, and the `Executor` interface from `mesos.interface`).

For ease of review and confidence, I intend to change `src/test/python` in a follow-up review.


Diffs
-----

  src/main/python/apache/aurora/client/api/command_runner.py c7238e274e53138187c2fe6fe5f14b7ae5f43ba2

  src/main/python/apache/aurora/client/base.py 487f8e73fa978b150f2e5b60e0f64c71ce783c12 
  src/main/python/apache/aurora/client/cli/task.py d1f2568ac0afdd95c65523fde41f0dd16670a7a8

  src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py b3e8bf1e924999306e0b8a1314273b22c51028e7

  src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d

  src/main/python/apache/aurora/executor/common/executor_detector.py a07bfc34caa5f86153ace8184b061e253c39e92e

  src/main/python/apache/aurora/executor/executor_base.py 1db97cc8c12752d4eca339a7680ba963a66ffbce


Diff: https://reviews.apache.org/r/37859/diff/


Testing
-------


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message