aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 37825: Adding minimal implementation of the external tier config.
Date Thu, 27 Aug 2015 17:54:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37825/#review96714
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 117)
<https://reviews.apache.org/r/37825/#comment152355>

    I think this function should also parse the data into Map<String, TierInfo>. The
earlier we parse data (and error out if data is invalid) the better IMHO.



src/main/java/org/apache/aurora/scheduler/TierManager.java (line 68)
<https://reviews.apache.org/r/37825/#comment152357>

    If applying a default value, I think we should log it.



src/test/java/org/apache/aurora/scheduler/TierManagerTest.java (line 26)
<https://reviews.apache.org/r/37825/#comment152356>

    Please add a test for the config for having keys that are not expected. I would expect
the scheduler to reject such files because they are malformed.


- Zameer Manji


On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37825/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 6:07 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1437
>     https://issues.apache.org/jira/browse/AURORA-1437
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The external config file is optional for now as tiers are not fully defined yet.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 744b4a35c61e749734e222b3d4cbd296927665aa

>   examples/vagrant/upstart/aurora-scheduler.conf 789a3a0315e8530880999432aa9b1e7d0f57d1ff

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java d4bc6b9bb10c982fb6a2458d7fdd12bddbe98eca

>   src/main/java/org/apache/aurora/scheduler/TierManager.java 652afece17a7eb09b0ca68066707b1b8fbf024f0

>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java eb0207114e1b93968cb65832f154a9cd3bc3232e

>   src/test/resources/org/apache/aurora/scheduler/tiers-example.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37825/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message