aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.
Date Thu, 27 Aug 2015 17:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/#review96710
-----------------------------------------------------------


Should this be a part of an epic to rename all internal occurences? Quick check shows up plenty
of mentiones in docs and public (e.g. thrift) APIs. I think consistency is important and we
should not lose track of other work in this area.

- Maxim Khutornenko


On Aug. 27, 2015, 5:37 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37847/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 5:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change the UI to refer to Mesos Agents instead of Mesos Slaves.
> 
> This change also moves the /slaves endpoint to /agents and adds a compatibility redirect.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 06ee83335bde7053227de0bd516ca8ce24f8ce55

>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java b64e18c4d5278e6cdb2e480043a45e6ec4f87484

>   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919

>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 4a8a07222d65681e77c90566be9dce9283c7be65

>   src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979

>   src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7

> 
> Diff: https://reviews.apache.org/r/37847/diff/
> 
> 
> Testing
> -------
> 
> Tested /slaves and /agents in vagrant.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message