aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 37593: Modifying resource counters to support revocable resources.
Date Thu, 20 Aug 2015 01:28:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37593/#review95899
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Aug. 18, 2015, 3:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37593/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 3:58 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1439
>     https://issues.apache.org/jira/browse/AURORA-1439
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This could have been a bit easier if we did not expose zero-counters by default. The
full counter name expansion is now handled by SLOT_GROUPS.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 3b4fbb6c625061b0c3afa57482a7ba99a9c6ced5

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 74a654619b56301c8745eac47cfb9d38b9d7de66

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 6dbc5d6c052f59a0d326ecfe33a92669d4b38e13

>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 39c055da8f2552bd11705f7f1e147ffc98b99f7c

>   src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java b6623d5e1160e97af397b1a54da3f5d4304dcceb

> 
> Diff: https://reviews.apache.org/r/37593/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message