aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 37560: Adding TierManager initial implementation.
Date Tue, 18 Aug 2015 18:22:44 GMT


> On Aug. 18, 2015, 6 p.m., Aurora ReviewBot wrote:
> > Master (22f9cbb) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :api:compileJava UP-TO-DATE
> > :api:generateThriftResources
> > :api:processResources UP-TO-DATE
> > :api:classes
> > :api:jar
> > :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> > 
> > :processResources
> > :classes
> > :jar
> > :startScripts
> > :distTar
> > :distZip
> > :assemble
> > :compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > 
> > :processJmhResources UP-TO-DATE
> > :jmhClasses
> > :checkstyleJmh
> > :jsHint
> > :checkstyleMain
> > :compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/ResourcesTest.java:121:
error: CPU has private access in Resources
> >         Resources.from(createOffer(resources)).filter(Resources.CPU).slot());
> >                                                                ^
> > 1 error
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileTestJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 1 mins 51.786 secs
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

Got too gready with visibility downgrade. Fixed and added more coverage.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37560/#review95748
-----------------------------------------------------------


On Aug. 18, 2015, 5:04 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37560/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 5:04 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1437
>     https://issues.apache.org/jira/browse/AURORA-1437
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Introducing `TierManager` implementation. This diff addresses basic needs within the
Oversubscription feature scope.
> 
> Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately.
> 
> More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b

>   src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163

>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b

> 
> Diff: https://reviews.apache.org/r/37560/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message