aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 37560: Adding TierManager initial implementation.
Date Tue, 18 Aug 2015 17:04:20 GMT


> On Aug. 18, 2015, 2:34 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/Resources.java, lines 52-63
> > <https://reviews.apache.org/r/37560/diff/1/?file=1042679#file1042679line52>
> >
> >     Do `CPU`, `REVOCABLE` and `NON_REVOCABLE` need to be public? I don't see them
accessed anywhere other than tests? Can we s/public// and add `@VisibleForTesting`?

The REVOCABLE/NON_REVOCABLE will likely be needed public when I get to preemptor diff (coming
next). The CPU does not have to be public. I'll lower the visibility for everything anyway
to keep the diff logically consistent.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37560/#review95719
-----------------------------------------------------------


On Aug. 18, 2015, 12:35 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37560/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 12:35 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1437
>     https://issues.apache.org/jira/browse/AURORA-1437
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Introducing `TierManager` implementation. This diff addresses basic needs within the
Oversubscription feature scope.
> 
> Only TaskAssigner is modified to use TierManager. Other consumers will be addressed separately.
> 
> More about the TierManager concept here: https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 40df26234ad9959227d8a56edbe563f252d47560

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 45265ea6cef5e26a3d7303a9653cfca110528d4b

>   src/main/java/org/apache/aurora/scheduler/TierInfo.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java ca4b5b0b01c7b347fc90f40d77f96cf9d4d94163

>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 88958d1510cf9402a7d1e422de9f7918004e188b

> 
> Diff: https://reviews.apache.org/r/37560/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message