aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 37153: Resources: reversing Resource/ResourceSlot relationship
Date Thu, 06 Aug 2015 01:24:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37153/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

This reverses ResourceSlot->Resources relationship making ResourceSlot an anonymous representation
of the Resources class. ResourceSlot is now used for calculations and when Mesos resource
traits are irrelevant. 

There is some redundancy between Resources and ResourceSlot (i.e. how resource vector is stored)
that will be eliminated once Resouces starts using Mesos resource vector (Iterable<Resource>).


Will not apply cleanly as it branched off of 37144.


Diffs
-----

  src/jmh/java/org/apache/aurora/benchmark/Offers.java e40db747047792fedf237e9e22139e84264bcb95

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ecadb3ee70236a61dedbcd15f6897f1bc27b1680

  src/main/java/org/apache/aurora/scheduler/Resources.java ea7ce24969171a04ebee2419ad7d5111a12d3538

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 554a380bdb4ef69561259cdbfbc361694041571e

  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 260e11e910e97c1057351c206f0f763c04d4502a

  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 54ffd8e3e76527e39c55ac735c3d1e71b317cbf4

  src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 325f55640648151ae19e0c18c6961aeff10bfac3

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16

  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 429341523f131a4812d37c77962b9c25f8dd9e53

  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc

  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java b96c84cbec083df5907b8c4293ac0f6fb77d3758

  src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java b4dbab77ec0f8e843dd5248655b10fc7b7794398

  src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 115dc085ec953dde19614fc7d073c6ca5fc7b07d

  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d

  src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java abbc8e34ed2a02d22c4c82cea6e1b69311d80754

  src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6441ffdd0d04314d8b45cbed81fce07e3762a740

  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441

  src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7

  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 997d3261656f1912968a09c5982ce3786bda0231

  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c9c6f5d47300996abab3b0b9045022fe2dbb18ee


Diff: https://reviews.apache.org/r/37153/diff/


Testing
-------


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message