aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 37137: Add indications of continued activity to the Update page.
Date Wed, 05 Aug 2015 20:55:05 GMT


> On Aug. 5, 2015, 8:49 p.m., Zameer Manji wrote:
> > src/main/resources/scheduler/assets/css/app.css, line 436
> > <https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436>
> >
> >     If we are going to add the -webkit prefix then I think we should do the same
for -moz. Otherwise I think we should remove the -webkit prefix and just stick to the standard
css3 names.

-moz is not necessary. Firefox has supported prefix-less keyframes since version 16 (current
stable is 39) which was released in 2012. Current Safari does not work without the -webkit
prefix, thus the reason why it's necessary.


> On Aug. 5, 2015, 8:49 p.m., Zameer Manji wrote:
> > src/main/resources/scheduler/assets/update.html, line 103
> > <https://reviews.apache.org/r/37137/diff/2/?file=1032843#file1032843line103>
> >
> >     My lack of angular knowledge is showing: where is the 'inProgress' expression
defined?

It's defined on the scope in the controller: https://github.com/apache/aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L286


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37137/#review94303
-----------------------------------------------------------


On Aug. 5, 2015, 8:28 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37137/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 8:28 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1125
>     https://issues.apache.org/jira/browse/AURORA-1125
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add indications of continued activity to the Update page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/css/app.css ba26accceb1da7dcc89739ceb4524ab6b5c4a11d

>   src/main/resources/scheduler/assets/js/directives.js 408ee21416621d5d1c195752e1b1c5c2757f0664

>   src/main/resources/scheduler/assets/loadingFooter.html PRE-CREATION 
>   src/main/resources/scheduler/assets/update.html a5c27f3db3ca41a2fdf4c396d221ff1be9d20bdf

> 
> Diff: https://reviews.apache.org/r/37137/diff/
> 
> 
> Testing
> -------
> 
> See attached video of the progress indicators in action.
> 
> 
> File Attachments
> ----------------
> 
> Progress indicators in action
>   https://reviews.apache.org/media/uploaded/files/2015/08/05/b4e2fab2-9a3e-4910-b02f-e31de2631e87__update-page.mov
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message