aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 37137: Add indications of continued activity to the Update page.
Date Wed, 05 Aug 2015 20:09:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37137/#review94299
-----------------------------------------------------------


Master (61c63ea) is red with this patch.
  ./build-support/jenkins/build.sh

:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
Missing space after 'function'. (/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/directives.js:203:47)
> auroraUI.directive('loadingFooter', function() {

Missing semicolon. (/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/directives.js:207:6)
> }

:jsHint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command '/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk1.8.0_45/bin/java''
finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 1 mins 33.605 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 5, 2015, 7:34 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37137/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 7:34 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1125
>     https://issues.apache.org/jira/browse/AURORA-1125
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add indications of continued activity to the Update page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/css/app.css ba26accceb1da7dcc89739ceb4524ab6b5c4a11d

>   src/main/resources/scheduler/assets/js/directives.js 408ee21416621d5d1c195752e1b1c5c2757f0664

>   src/main/resources/scheduler/assets/loadingFooter.html PRE-CREATION 
>   src/main/resources/scheduler/assets/update.html a5c27f3db3ca41a2fdf4c396d221ff1be9d20bdf

> 
> Diff: https://reviews.apache.org/r/37137/diff/
> 
> 
> Testing
> -------
> 
> See attached video of the progress indicators in action.
> 
> 
> File Attachments
> ----------------
> 
> Progress indicators in action
>   https://reviews.apache.org/media/uploaded/files/2015/08/05/b4e2fab2-9a3e-4910-b02f-e31de2631e87__update-page.mov
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message