Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 912B218076 for ; Fri, 31 Jul 2015 00:22:34 +0000 (UTC) Received: (qmail 86712 invoked by uid 500); 31 Jul 2015 00:22:34 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 86658 invoked by uid 500); 31 Jul 2015 00:22:34 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 86642 invoked by uid 99); 31 Jul 2015 00:22:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jul 2015 00:22:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1E1A7D7E92; Fri, 31 Jul 2015 00:22:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1906140183583271014==" MIME-Version: 1.0 Subject: Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log. From: "Bill Farner" To: "Bill Farner" Cc: "Joe Smith" , "Aurora" Date: Fri, 31 Jul 2015 00:22:33 -0000 Message-ID: <20150731002233.1540.42440@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34020/ X-Sender: "Bill Farner" References: <20150731001437.1540.68195@reviews.apache.org> In-Reply-To: <20150731001437.1540.68195@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============1906140183583271014== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 243) Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. - Bill Farner On July 31, 2015, 12:14 a.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34020/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 12:14 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1282 > https://issues.apache.org/jira/browse/AURORA-1282 > > > Repository: aurora > > > Description > ------- > > Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. > > Stat names will be unchanged as a result of this. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 > > Diff: https://reviews.apache.org/r/34020/diff/ > > > Testing > ------- > > $ ./gradlew build -Pq > > > Thanks, > > Joe Smith > > --===============1906140183583271014==--