Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9C1517BCD for ; Wed, 22 Jul 2015 22:42:48 +0000 (UTC) Received: (qmail 61241 invoked by uid 500); 22 Jul 2015 22:42:43 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 61188 invoked by uid 500); 22 Jul 2015 22:42:43 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 61169 invoked by uid 99); 22 Jul 2015 22:42:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 22:42:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5B7FEBEC72; Wed, 22 Jul 2015 22:42:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6604983858988573253==" MIME-Version: 1.0 Subject: Re: Review Request 34337: Add Docker Parameters From: "Mauricio Garavaglia" To: "Bill Farner" Cc: "Mauricio Garavaglia" , "Aurora ReviewBot" , "Aurora" Date: Wed, 22 Jul 2015 22:42:41 -0000 Message-ID: <20150722224241.10542.88188@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mauricio Garavaglia" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34337/ X-Sender: "Mauricio Garavaglia" References: <20150718235040.17362.99214@reviews.apache.org> In-Reply-To: <20150718235040.17362.99214@reviews.apache.org> Reply-To: "Mauricio Garavaglia" X-ReviewRequest-Repository: aurora --===============6604983858988573253== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ ----------------------------------------------------------- (Updated July 22, 2015, 10:42 p.m.) Review request for Aurora and Bill Farner. Changes ------- Adding relevant issue. Bugs: AURORA-1396 https://issues.apache.org/jira/browse/AURORA-1396 Repository: aurora Description ------- Support Arbitrary Docker Parameters in DockerContainer Diffs ----- api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70faa7125eee407fc57e8a297e18a51661f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165ad34e46653dad95918e0058ebd3f2ee57f src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31 Diff: https://reviews.apache.org/r/34337/diff/ Testing ------- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia --===============6604983858988573253==--