Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0266072620269896166=="
MIME-Version: 1.0
Subject: Re: Review Request 36511: Removes version on virtual pacakge in
 debian
 control
From: "Benjamin Staffin" <ben@folsomlabs.com>
To: "Benjamin Staffin" <ben@folsomlabs.com>,
 "Dan Norris" <protochron@gmail.com>, "Zameer Manji" <zmanji@apache.org>
Cc: "Andrew Jorgensen" <andrew@andrewjorgensen.com>,
 "Aurora" <reviews@aurora.apache.org>
Date: Wed, 15 Jul 2015 17:56:53 -0000
Message-ID: <20150715175653.17362.73761@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Benjamin Staffin" <noreply@reviews.apache.org>
References: <20150715175053.17363.26371@reviews.apache.org>
In-Reply-To: <20150715175053.17363.26371@reviews.apache.org>
Reply-To: "Benjamin Staffin" <ben@folsomlabs.com>

--===============0266072620269896166==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91775
-----------------------------------------------------------

Ship it!


Thank you - I was not aware of the restriction against having versions on virtual package dependencies.

- Benjamin Staffin


On July 15, 2015, 10:50 a.m., Andrew Jorgensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36511/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 10:50 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, Dan Norris, and Zameer Manji.
> 
> 
> Bugs: AURORA-1400
>     https://issues.apache.org/jira/browse/AURORA-1400
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> java-runtime-headless is a virtual package and cannot have a version
> specified. The consequence of this is that the built packages require openjdk-8
> be installed which prevented the packages from working with oracle-java8.
> java8-runtime-headless is a virtual package provided by both openjdk-8
> and oracle-java8 so the resulting debian packages can be installed on a
> machine with either versions of java8 installed.
> 
> 
> Diffs
> -----
> 
>   build-support/packaging/debian/control ff62ea19f27e1937549aca1c1effd108626453bc 
> 
> Diff: https://reviews.apache.org/r/36511/diff/
> 
> 
> Testing
> -------
> 
> Started two docker containers, one with oracle-java8 and the other with openjdk-8. I was able to install the aurora-scheduler package in both containers with this change.
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>


--===============0266072620269896166==--