Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD58A189C3 for ; Thu, 9 Jul 2015 19:07:08 +0000 (UTC) Received: (qmail 8024 invoked by uid 500); 9 Jul 2015 19:07:08 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 7979 invoked by uid 500); 9 Jul 2015 19:07:08 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 7959 invoked by uid 99); 9 Jul 2015 19:07:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 19:07:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E1C19BB007; Thu, 9 Jul 2015 19:07:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3374589319052125153==" MIME-Version: 1.0 Subject: Re: Review Request 36357: Relax the transaction isolation in H2 to match MemStorage behavior. From: "Bill Farner" To: "Zameer Manji" Cc: "Bill Farner" , "Aurora" Date: Thu, 09 Jul 2015 19:07:07 -0000 Message-ID: <20150709190707.1573.98961@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36357/ X-Sender: "Bill Farner" References: <20150709180508.1572.78075@reviews.apache.org> In-Reply-To: <20150709180508.1572.78075@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============3374589319052125153== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 9, 2015, 6:05 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 115 > > > > > > Once H2 becomes the default/only in memory storage, are we going to revisit the LOCK_MODE? > > Bill Farner wrote: > Yes. My TODO in the newly-added test case advises this. > > Zameer Manji wrote: > I think filing a ticket for this would be nice. It is good tech debt work. https://issues.apache.org/jira/browse/AURORA-1389 - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36357/#review91132 ----------------------------------------------------------- On July 9, 2015, 7:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36357/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 7:04 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1386 > https://issues.apache.org/jira/browse/AURORA-1386 > > > Repository: aurora > > > Description > ------- > > See h2 docs [1] for context on this setting. > > The patch in `DbModule` could have been much smaller, but i did a mini refactor to supply a map of args to centralize concatenation and make for easier commenting on each arg. > > [1] http://www.h2database.com/html/advanced.html#transaction_isolation > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 23bf0acf33b7a130bec98e33259bde1b3dc5c7cb > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java c8a2d81bfc48ee8d9cb81aecea1baba920b2b948 > > Diff: https://reviews.apache.org/r/36357/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============3374589319052125153==--