Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============0825823424996531765=="
MIME-Version: 1.0
Subject: Re: Review Request 35847: Split http lifecycle into a composition
 layer.
From: "Brian Wickman" <wickman@apache.org>
To: "Maxim Khutornenko" <maxim@apache.org>,
 "Brian Brazil" <brian.brazil@boxever.com>
Cc: "Brian Wickman" <wickman@apache.org>, "Aurora" <reviews@aurora.apache.org>
Date: Wed, 01 Jul 2015 17:37:04 -0000
Message-ID: <20150701173704.13307.32370@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brian Wickman" <noreply@reviews.apache.org>
References: <20150630001843.13308.81794@reviews.apache.org>
In-Reply-To: <20150630001843.13308.81794@reviews.apache.org>
Reply-To: "Brian Wickman" <wickman@apache.org>

--===============0825823424996531765==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On June 30, 2015, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/executor/http_lifecycle.py, line 70
> > <https://reviews.apache.org/r/35847/diff/5/?file=991685#file991685line70>
> >
> >     Use Event.wait() instead?

I believe it's implemented this way for the purposes of mocking.


> On June 30, 2015, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/configuration-reference.md, lines 455-457
> > <https://reviews.apache.org/r/35847/diff/5/?file=991681#file991681line455>
> >
> >     Perhaps add that this is a courtesy call and a task will still be shut down within 5 seconds regardless of the response here.

Fixed the wording (also removed the info about the fixed `health` port.)


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35847/#review89829
-----------------------------------------------------------


On June 24, 2015, 10:45 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35847/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Brian Brazil and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1368
>     https://issues.apache.org/jira/browse/AURORA-1368
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Move shutdown endpoints to the Job config since the lifecycle is controlled by Aurora and not Thermos.
> Split the lifecycle management into a composition layer that can more readily be tested.
> 
> Also, derp, just realized I did not update the documentation.  Revision forthcoming.
> (Also comment on the 'union' style here -- not sure what is preferable.)
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   src/main/python/apache/aurora/config/schema/base.py 9a6f8a16f85c324ec75352710e19249443bf2c6b 
>   src/main/python/apache/aurora/config/thrift.py 0a3e91011eccf8573feb296bd7f72913622e0ce0 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/http_lifecycle.py PRE-CREATION 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 7bcd6c42f50665eac2e7f17b84e63f2ea7fb4d4f 
>   src/main/python/apache/thermos/config/schema_base.py a85def9eea25fa01020ca2dda4e9cefe861c4a5f 
>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/common/fixtures.py 37d032beb66a67cfd3cfcea272747a2915a745ff 
>   src/test/python/apache/aurora/executor/test_http_lifecycle.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 3569a6abf84d5144d2e268b0a86c82285ffe2b2b 
> 
> Diff: https://reviews.apache.org/r/35847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


--===============0825823424996531765==--