aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
Date Fri, 31 Jul 2015 01:43:08 GMT


> On July 31, 2015, 12:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243
> > <https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243>
> >
> >     Oh wow sorry for the poor guidance, this actually is not something we should
do.  In the last pass i convinced myself that this was using the local logger, but reaching
out to Stats' logger and changing it is not good behavior.
> >     
> >     I'd happily wait for the fork and live with the log noise rather than go this
direction.
> 
> Joe Smith wrote:
>     Aha, gotcha- no worries, I'll update the ticket and discard this.
> 
> Joe Smith wrote:
>     Well- to make sure I learn to fish- this is because we're then modifying Stats, which
typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html)
instead?)

Yeah, it's just kind of sneaky.  Even if the operator tries to configure the logging system,
or we try to adjust the log level on the fly, this code undermines that.  That might be okay
for the logging done today, but who knows about tomorrow.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------


On July 31, 2015, 12:14 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 12:14 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1282
>     https://issues.apache.org/jira/browse/AURORA-1282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable
stats names.
> 
> Stat names will be unchanged as a result of this.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893

>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478

> 
> Diff: https://reviews.apache.org/r/34020/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message