aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 34020: Normalize SLA stat names
Date Thu, 30 Jul 2015 17:34:48 GMT


> On July 8, 2015, 10:49 a.m., Stephan Erb wrote:
> > Joe, have you tested this change in vagrant?

I decided to change direction here, so we won't be changing stats names.


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90933
-----------------------------------------------------------


On July 30, 2015, 10:32 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 10:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1282
>     https://issues.apache.org/jira/browse/AURORA-1282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
> 
> Stat names will be unchanged as a result of this.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478

> 
> Diff: https://reviews.apache.org/r/34020/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test 
> 
>     BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message