aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.
Date Tue, 28 Jul 2015 11:03:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review93270
-----------------------------------------------------------


Please reconsider the removal of the `build-support/release/make-python-sdists` script.

We are using `apache.aurora.client` and its dependencies in production. We install the client
sdist into a virtualenv and then use a thin wrapper around `apache.aurora.client.api.AuroraClientAPI`
in order to control our cluster. Using the pex does neither seem to offer the same flexibility
nor the same performance (subprocess call and thrift connections take rather long).

- Stephan Erb


On July 28, 2015, 2:58 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36700/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 2:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-1381
>     https://issues.apache.org/jira/browse/AURORA-1381
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The meaning of the targets under `src/main/python/apache/thermos/cli/bin/BUILD` and `src/main/python/apache/thermos/observer/bin/BUILD`
changed recently, which bit several people (including our own packaging).  This removes targets
that Aurora users should not be consuming.
> 
> 
> Diffs
> -----
> 
>   README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 
>   build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 
>   build-support/packaging/debian/rules 23828c02b73f007393d2ed4ce69c010cebf07e57 
>   build-support/packaging/rpm/aurora.spec 0c4c106a1730ee7e4e62c7ba778e7f0e2cb44771 
>   build-support/release/make-python-sdists 9608f68e16243da01434ce2fc7d61bb7c7efd712 
> 
> Diff: https://reviews.apache.org/r/36700/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> (as far as it currently gets on master, anyhow, due to AURORA-1409)
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message