aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zane Silver" <zsil...@luminatewireless.com>
Subject Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs
Date Wed, 22 Jul 2015 18:29:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/
-----------------------------------------------------------

(Updated July 22, 2015, 6:29 p.m.)


Review request for Aurora and Zameer Manji.


Bugs: AURORA-1405
    https://issues.apache.org/jira/browse/AURORA-1405


Repository: aurora


Description
-------

Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.

When more than one zookeeper host was specified in the clusters.json file, only the last host
was accessed through the specified zk_port. The client would attempt to connect to all other
zookeeper hosts using the default port (2181).

For example, in clusters.json:
[{
  "name": "<my_cluster>",
  "zk": "host1.domain.com,host2.domain.com,host3.domain.com",
  "zk_port": 2626,
  "scheduler_zk_path": "/cluster/aurora/scheduler",
  "slave_run_directory": "latest"
}
...
]
I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181,
host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only
update the last host in the host string-list. This change allows the client to properly connect
to multiple zookeeper hosts using a port other than the specified port.

Note, that the KazooClient accepts a comma-separated string of hosts.


Diffs
-----

  src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2


Diff: https://reviews.apache.org/r/36697/diff/


Testing
-------

This is a simple change, but tested to make sure client can still connect to each zookeeper
host. Then verified that all hosts are now accessed through the correct port, not just the
default (port 2181). Also viewable by Aurora client INFO logs.


Thanks,

Zane Silver


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message