aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 36666: Break apart async package and AsyncModule into purpose-specific equivalents.
Date Tue, 21 Jul 2015 23:51:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36666/
-----------------------------------------------------------

(Updated July 21, 2015, 11:51 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

I've found myself wanting to split this multi-purpose package and module for a while now.
 Doing so in prep of addressing AURORA-1395 with a new [Scheduled]ExecutorService facade.

This splits the contents of `org.apache.aurora.scheduler.async` into 4 packages under org.apache.aurora.scheduler:
**offers**
OfferManager
RandomJitterReturnDelay

**preemptor**
BiCache
ClusterState[Impl]
PendingTaskProcessor
PreemptionProposal
PreemptionVictim[Filter]
Preemptor
PreemptorMetrics

**pruning**
TaskHistoryPruner
JobUpdateHistoryPruner

**reconciliation**
KillRetry
TaskReconciler
TaskTimeout

**scheduling**
RescheduleCalculator
TaskGroup[s]
TaskScheduler
TaskThrottler


Diffs
-----

  src/jmh/java/org/apache/aurora/benchmark/Offers.java b8e6cb574a76f5105bea2216bcfcc48db0c2ba92

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java d9e5199862f9328ba812e54f231f1c9a43d54c24

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java e08d16ed3260ca5c0d617a66d288ac928432a8df

  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 45849b52ce85dd8eb1f28d4ab0386d2eafd9209d

  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 6d710128a2723dc9d39bb2d0ca7544d10739a6c8

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 1a158b4e0be94762ad0480e8ce74b19bacc90c97

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java d2c172074092cd6e625a02646c9f12e37538b40b

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8c2d7512e58d34952d3c74d488c2bd5d4ea0d452

  src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java b4163435ea337a9976fae2f84850af0320ab9884

  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java b125c1c81309c521219f856c21a590f6e574c31c

  src/main/java/org/apache/aurora/scheduler/async/OfferManager.java e60d01ed2de2a51dea3adb2682fe480fc623e002

  src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 6a8c96791b21e1d8a91d5f4ada71486f81d3e275

  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6a0c0a9b933546c1581d3e29ba53eb86c58fbc39

  src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 635419b2558f646cd46650013d9582e9f404582c

  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 1580404a36bbab6b612b8188c4a649d4a77118e0

  src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 7b6c0639fba6a322529f17c9a69c3b28ea7d2432

  src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 68d2e77f198df31faa16bb85bd8333ed0dd3aa66

  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java a500e55cb52fe89917d8499a42e2a2eb5032c109

  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java c8f2005eec87506d1133ab618ffa6195f074480f

  src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java e250f3330504c3c3737564174ecc2943cb7dd93b

  src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 382099f47b132065c159111754b91511e4b3fba1

  src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 38610b21c5404dfcd938a2541c0f407a8fd259d2

  src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java d7a0c54d4dc3434359e5d4618835a2d2730d23f0

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java 1f1eb4c1f2f2b995d616b70ba9e3d149eea413d0

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionProposal.java 7a03168ab6997a9ad13ec3692249a2ac75f89bd6

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictim.java f196b212d2b2562e941100d17364b2442bce058f

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimFilter.java 75e23706df954b0cec77e7afe6c3f7dbfc258162

  src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java a2d5fcfacb8b23c5afcd200c6ae36a4b2ca176ef

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorMetrics.java 22a15330970a3f52b0c0b5307a2b90339f1c1d2e

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 3d9e27b673c10ccbb78a3f535d991a3f5e5433fa

  src/main/java/org/apache/aurora/scheduler/http/Offers.java b991616a5921fdfa42cc47935d2a6219e14041ed

  src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 82b6f5043146bc47927e4b9aefe314ce5c9371cf

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 6f0669317c6a1aadd9cadb117aa00328d0707d81

  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java ff33d0ba01794b3308be4a8baa04b4f8dbb82d3c

  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 825e7727d965d7d9e023da09d38e71586cc2b77f

  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 4ed6b159afda3f118e8ae28d03fdf796cbd98149

  src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java cb549a15c7483b5050d248041e32ea71a016f5b4

  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java a295fe89eec9ad4e9cd39ed1a626f2a5c472d553

  src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java 874a12416c7d7a6f1b4955e923b75df23b0df2a8

  src/test/java/org/apache/aurora/scheduler/async/Offers.java 8293dd181b0d062e89776fdc1205c1c227d6bb6c

  src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java 1aed40c4f2fa874a57e5eb279260383d745470c7

  src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java 131bd826dfe47f40f3c27f29c095ed42953e316c

  src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 51256f4c0be2616aba2e8aea2edb9e6235d5d26f

  src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 6eaf3ce765c8e50b6724e40848ceb9105e1ab529

  src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 00114127c4cbd230babacdc7a819fc04d82f57e9

  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 45adb2efc8807e22b923cb5606d797758f063297

  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java ed15401877418f81b5e62319cffc61726610b5d5

  src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java cfa9d81c23252c6c501522f82915936f2dfaf92c

  src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java b98a8d76b8651de85ac7e8bb2591ccd41038dfb9

  src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java babc17f872759f24bd8d16052cc83b54ad0bdc66

  src/test/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImplTest.java 1572a08bc4737f6f35292b14c994432920f56e93

  src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
a0dbb2577d5ec94cd00f04b7135478106e28d548 
  src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimFilterTest.java
5fe8e2eb4560c6e3f10ee39edec47a17fde3f31d 
  src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimTest.java bb93b638f6d63bb9f449ab1b4dc8a9c9bca14f40

  src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java d36499f405d98611d26ed00a7ef0ea6473f43a85

  src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java 2c20571c6b3f5d9712e7928d9a5ffe50772c53c3

  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 0d9aefff34b9a138e30747674218c2ba119b7627

  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 49af15b8e8be242ac3f7de4ff5268793aaf2f837

  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java dba194563300973c347f8c64d040477152d3b6da

  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8b99e0fac429bcbb16bd769890dcae902e3f022e


Diff: https://reviews.apache.org/r/36666/diff/


Testing (updated)
-------

Confirmed end-to-end tests pass, and ./gradlew run works.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message