aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
Date Wed, 15 Jul 2015 18:08:15 GMT


> On July 15, 2015, 9:50 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 169
> > <https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line169>
> >
> >     For better readability, how about `max_update_instance_failures`?

Done.


> On July 15, 2015, 9:50 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 171
> > <https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line171>
> >
> >     s/scheduler datastore/storage/

Done.


> On July 15, 2015, 9:50 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 173
> > <https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line173>
> >
> >     Unfortunately, this will not work as you expect and derive from the value of
`-max_tasks_per_job`.  This will always capture the default value (4000) since it is evaluated
before the arg is populated.  In fact, this would cause a failure if `-max_tasks_per_job`
was set on the command line, since args prevent setting a value after it has been read.
> >     
> >     The best way i can see to accomplish this while maintaining the relationship
is to extract constants:
> >     ```
> >     private static final int DEFAULT_MAX_TASKS_PER_JOB = 4000;
> >     private static final int DEFAULT_MAX_INSTANCE_UPDATE_EVENT_FAILURES =
> >         DEFAULT_MAX_TASKS_PER_JOB * 5;
> >     ```
> >     
> >     There isn't a clean way to have this multiplier effect that Just Works, so i
suggest you just set it to 20000 and leave a comment near `MAX_TASKS_PER_JOB` suggesting that
this arg be changed if the default is changed there.

Aha, good to know. Thanks for catching that! Let me know if you think that comment is sufficient.


> On July 15, 2015, 9:50 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1123
> > <https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line1123>
> >
> >     This first part can be ommitted, since it's effectively covered by `MAX_TASKS_PER_JOB`.

Done.


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/#review91749
-----------------------------------------------------------


On July 14, 2015, 5:30 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36436/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 5:30 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1096
>     https://issues.apache.org/jira/browse/AURORA-1096
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent job updates from allowing unbounded instance events
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d28baba7618ebb194a61455971786aef46abd8eb 
> 
> Diff: https://reviews.apache.org/r/36436/diff/
> 
> 
> Testing
> -------
> 
> `./gradlew build -Pq`
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message