aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Renan DelValle" <>
Subject Re: Review Request 36289: Custom executor support for Scheduler
Date Wed, 15 Jul 2015 01:10:44 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 15, 2015, 1:10 a.m.)

Review request for Aurora.


Created simple test for ExecutorSettingsLoader.
Fixed broken tests as a result of code changes.
Fixed code style accoring to guidelines.

Repository: aurora


What was done:
Added support for custom executors in the Scheduler via a config file. 
Removed command line arguments that were moved over to the config file.

Extending the client to support custom executors.

This contains initial config file with support for thermos and limited support for the mesos
commandline executor. Mesos-command line executor needs support from the client side in order
to function at a better capacity. 

Currently, this uses the current client to launch both tasks, meaning as long as the client
sends a thrift call, the scheduler will schedule a task, be it a mesos-command task with a
preconfigured command temporarily set in the config file or a custom executor task. 

*Support for custom executors in the client must be added in order to fully utilize this feature.*

Diffs (updated)

  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 85052ac8e4dde85fbcd85ce839d0647f5632d74b

  examples/vagrant/upstart/aurora-scheduler.conf f261c8dcc760151d5a41a986d867585c3a544123

  src/dist/etc/executors.json PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/ PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/ 554a380bdb4ef69561259cdbfbc361694041571e

  src/main/java/org/apache/aurora/scheduler/mesos/ 325f55640648151ae19e0c18c6961aeff10bfac3

  src/main/java/org/apache/aurora/scheduler/mesos/ c0d165ad34e46653dad95918e0058ebd3f2ee57f

  src/test/java/org/apache/aurora/scheduler/app/ PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/app/ 23c2693f1dfd589043c60ab22e302fb81e62335d

  src/test/java/org/apache/aurora/scheduler/mesos/ c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a

  src/test/java/org/apache/aurora/scheduler/mesos/ ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7

  src/test/resources/org/apache/aurora/scheduler/app/executor-settings-example.json PRE-CREATION



./gradlew test
895 tests completed, 44 failed, 3 skipped


Renan DelValle

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message