aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 36490: Use Provider<Optional<Subject>> instead of optional injection for Shiro audit logging.
Date Wed, 15 Jul 2015 00:02:19 GMT


> On July 14, 2015, 4:52 p.m., Aurora ReviewBot wrote:
> > Master (d9dac92) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :api:classesThriftEntities
> > :api:compileJava UP-TO-DATE
> > :api:generateThriftResources
> > :api:processResources UP-TO-DATE
> > :api:classes
> > :api:jar
> > :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:136:
error: incompatible types: no instance(s) of type variable(s) T exist so that Optional<T>
conforms to ? extends Optional<Subject>
> >       bind(new TypeLiteral<Optional<Subject>>() {}).toProvider(Optional::empty);
> >                                                                ^
> >   where T is a type-variable:
> >     T extends Object declared in method <T>empty()
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java:143:
error: no suitable method found for toProvider(SecurityUt[...]bject)
> >     bind(Subject.class).toProvider(SecurityUtils::getSubject).in(RequestScoped.class);
> >                        ^
> >     method LinkedBindingBuilder.toProvider(com.google.inject.Provider<? extends
Subject>) is not applicable
> >       (argument mismatch; bad return type in method reference
> >           Subject cannot be converted to ? extends Subject)
> >     method LinkedBindingBuilder.toProvider(Class<? extends javax.inject.Provider<?
extends Subject>>) is not applicable
> >       (argument mismatch; Class is not a functional interface)
> >     method LinkedBindingBuilder.toProvider(TypeLiteral<? extends javax.inject.Provider<?
extends Subject>>) is not applicable
> >       (argument mismatch; TypeLiteral is not a functional interface)
> >     method LinkedBindingBuilder.toProvider(Key<? extends javax.inject.Provider<?
extends Subject>>) is not applicable
> >       (argument mismatch; Key is not a functional interface)
> > Note: Some messages have been simplified; recompile with -Xdiags:verbose to get
full output
> > 2 errors
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 1 mins 33.58 secs
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

This looks like: https://bugs.openjdk.java.net/browse/JDK-8051402


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36490/#review91683
-----------------------------------------------------------


On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36490/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 4:48 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1352
>     https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use injection of an optional value instead of optional injection.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java f547c4485eab97e4fe149eec9fa73af3ce807748

>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
a3b0a6bd573f04ff275a54b16f0ab5ebf139868e 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 63917363f392e6d970fb7e0cb91b840ca5db173e

>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39

> 
> Diff: https://reviews.apache.org/r/36490/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message