aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 36392: Improve diff output of aurora cli.
Date Tue, 14 Jul 2015 13:03:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36392/#review91611
-----------------------------------------------------------

Ship it!


Master (1a01a5b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 14, 2015, 12:51 p.m., Brian Brazil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36392/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 12:51 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use json.dumps to pretty print the executor config,
> and munge it to look right and not get messed with by
> the general pretty printer.
> Show newlines directly so that multi-line cmdlines look right.
> 
> Make DIFF_VIEWER work for things like "diff -u10"
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37

>   src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e

> 
> Diff: https://reviews.apache.org/r/36392/diff/
> 
> 
> Testing
> -------
> 
> Tested in vargant environment.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message