aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <>
Subject Re: Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.
Date Mon, 13 Jul 2015 23:11:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 13, 2015, 11:11 p.m.)

Review request for Aurora and Bill Farner.


Remove unused import that the commit hook missed.

Repository: aurora


Fix AuroraConfigLoader schema filtering when loading from string.

We have an internal tool that needs to serialize configs into a string and retrieve them from
stable storage.  We had deployed a client containing shutdown_endpoint then reverted it in but unfortunately deserialization broke the internal tool
since it was not filtering out the unknown attributes.

Diffs (updated)

  src/main/python/apache/aurora/config/ c8b045e9a668199feee0ac3cee9fac55fe09cf08

  src/test/python/apache/aurora/config/ 00b6eabadb8f4e40aba1191068e1ca04c78d1ff3



Added test, it broke.  Fixed code, tests passed.

Also updated tests to not create files when not necessary.


Brian Wickman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message