aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.
Date Mon, 13 Jul 2015 23:11:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36459/
-----------------------------------------------------------

(Updated July 13, 2015, 11:11 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Remove unused import that the commit hook missed.


Repository: aurora


Description
-------

Fix AuroraConfigLoader schema filtering when loading from string.

We have an internal tool that needs to serialize configs into a string and retrieve them from
stable storage.  We had deployed a client containing shutdown_endpoint then reverted it in
https://reviews.apache.org/r/35847/ but unfortunately deserialization broke the internal tool
since it was not filtering out the unknown attributes.


Diffs (updated)
-----

  src/main/python/apache/aurora/config/loader.py c8b045e9a668199feee0ac3cee9fac55fe09cf08

  src/test/python/apache/aurora/config/test_loader.py 00b6eabadb8f4e40aba1191068e1ca04c78d1ff3


Diff: https://reviews.apache.org/r/36459/diff/


Testing
-------

Added test, it broke.  Fixed code, tests passed.

Also updated tests to not create files when not necessary.


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message