aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
Date Mon, 13 Jul 2015 23:09:53 GMT


> On July 12, 2015, 11:38 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 169
> > <https://reviews.apache.org/r/36436/diff/1/?file=1009204#file1009204line169>
> >
> >     Give that this will be the only documentation of this feature, the doc string
could be a bit longer and explain that this option applies to the job update feature and limits
the `max_per_shard_failures` jobspec configuration.

Done (I believe, thatis. Let me know if you think this is clearer!)


> On July 12, 2015, 11:38 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 173
> > <https://reviews.apache.org/r/36436/diff/1/?file=1009204#file1009204line173>
> >
> >     Same as above. It is hard to understand the implications of this option without
reading the code.

Done. (But let me know what you think!)


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/#review91416
-----------------------------------------------------------


On July 12, 2015, 11:49 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36436/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 11:49 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1096
>     https://issues.apache.org/jira/browse/AURORA-1096
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent job updates from allowing unbounded instance events
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d28baba7618ebb194a61455971786aef46abd8eb 
> 
> Diff: https://reviews.apache.org/r/36436/diff/
> 
> 
> Testing
> -------
> 
> `./gradlew build -Pq`
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message