aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Brazil" <brian.bra...@boxever.com>
Subject Re: Review Request 36392: Improve diff output of aurora cli.
Date Fri, 10 Jul 2015 12:22:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36392/
-----------------------------------------------------------

(Updated July 10, 2015, 12:22 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
-------

Fix tests. I keep on forgettings they're in a different tree.


Repository: aurora


Description
-------

Use json.dumps to pretty print the executor config,
and munge it to look right and not get messed with by
the general pretty printer.
Show newlines directly so that multi-line cmdlines look right.

Make DIFF_VIEWER work for things like "diff -u10"


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37

  src/test/python/apache/aurora/client/cli/test_diff.py da52105b5c77419ff64e15a30a04f997f9216a7e


Diff: https://reviews.apache.org/r/36392/diff/


Testing
-------

Tested in vargant environment.


Thanks,

Brian Brazil


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message