aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 36372: TaskConfigManager: de-dupe task configs when inserting.
Date Thu, 09 Jul 2015 21:39:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36372/#review91208
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 9, 2015, 1:55 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36372/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 1:55 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1392
>     https://issues.apache.org/jira/browse/AURORA-1392
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This provides a better guarantee, as the code path to insert a task config now always
checks for an existing config.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 2f428513305e147b1b33fd5868b9ede8ae72ebb8

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java c1237b79c4792451e146e2ddd25401f5d56bbe71

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java f3f241dc6e692b76e7ad9a3e89db497664e124f6

>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 39177fde01542bb72084850b4662fcec2c98ff99

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 8d9792faa3fb3e00fcb47d132085ac0222716ca1

> 
> Diff: https://reviews.apache.org/r/36372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message