aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 34337: Add Docker Parameters
Date Mon, 06 Jul 2015 00:13:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90416
-----------------------------------------------------------

Ship it!


Master (82aa097) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> -----------------------------------------------------------
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb

> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> -------
> 
> Used Docker as the container of a Job. Included volumes and label parameters which are
correctly picked up by mesos when starting the task. The docker container gets the specified
label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases
docker containers for several weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message