Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E200C180BE for ; Tue, 30 Jun 2015 18:18:05 +0000 (UTC) Received: (qmail 21521 invoked by uid 500); 30 Jun 2015 18:18:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 21479 invoked by uid 500); 30 Jun 2015 18:18:05 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 21315 invoked by uid 99); 30 Jun 2015 18:18:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2015 18:18:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C14CCAC6AD; Tue, 30 Jun 2015 18:18:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0415694882576807764==" MIME-Version: 1.0 Subject: Re: Review Request 35990: Map Aurora task metadata to Mesos task labels From: "Zameer Manji" To: "Bill Farner" , "Zameer Manji" Cc: "Stephan Erb" , "Aurora" Date: Tue, 30 Jun 2015 18:18:03 -0000 Message-ID: <20150630181803.13308.82084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35990/ X-Sender: "Zameer Manji" References: <20150629155523.13308.65139@reviews.apache.org> In-Reply-To: <20150629155523.13308.65139@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============0415694882576807764== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 29, 2015, 8:55 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 244 > > > > > > I have been thinking about using mesos task labels to record the aurora job key. If we blindly copy the metadata over to the task labels, this might prevent us from doing that task in a backwards compatible manner. > > > > Perhaps the label keys should be prefixed? > > Stephan Erb wrote: > Using the components of a jobkey as labels is an excellent idea. > > Latest Mesos allows label injection using hooks at the master and slave level. I guess we should opt for an aurora specific prefix. How about `aurora_metadata_` as a prefix? Prefixing the keys with 'aurora_metadata_' sounds good to me. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89750 ----------------------------------------------------------- On June 30, 2015, 1:04 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35990/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 1:04 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1052 > https://issues.apache.org/jira/browse/AURORA-1052 > > > Repository: aurora > > > Description > ------- > > Map Aurora task metadata to Mesos task labels > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 > > Diff: https://reviews.apache.org/r/35990/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > > --===============0415694882576807764==--