Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E140D179FB for ; Mon, 29 Jun 2015 21:00:06 +0000 (UTC) Received: (qmail 40314 invoked by uid 500); 29 Jun 2015 21:00:06 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 40275 invoked by uid 500); 29 Jun 2015 21:00:06 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 39688 invoked by uid 99); 29 Jun 2015 21:00:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2015 21:00:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C770AABFD8; Mon, 29 Jun 2015 21:00:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5618385625958715253==" MIME-Version: 1.0 Subject: Re: Review Request 35954: Prevent quota from being set below current production reservation. From: "Zameer Manji" To: "Bill Farner" , "Joe Smith" , "Maxim Khutornenko" Cc: "Zameer Manji" , "Aurora" Date: Mon, 29 Jun 2015 21:00:04 -0000 Message-ID: <20150629210004.13308.83108@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35954/ X-Sender: "Zameer Manji" References: <20150629153502.13308.86653@reviews.apache.org> In-Reply-To: <20150629153502.13308.86653@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============5618385625958715253== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 29, 2015, 8:35 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, lines 81-82 > > > > > > I understand what you are trying to do here but we usually don't go that specific to control read/write access. Should just take a MutableStoreProvider instead. Done. > On June 29, 2015, 8:35 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, lines 162-163 > > > > > > String.format() may be easier to read here. Done. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89743 ----------------------------------------------------------- On June 29, 2015, 1:59 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35954/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 1:59 p.m.) > > > Review request for Aurora, Joe Smith, Maxim Khutornenko, and Bill Farner. > > > Bugs: AURORA-1375 > https://issues.apache.org/jira/browse/AURORA-1375 > > > Repository: aurora > > > Description > ------- > > Having quota below current production resesrvation is illogical and the scheduler should reject requests that would result in this. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7453680af5a518012f9779f82d0349e897c04994 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9af379c36d2e3e44f462ed5d431f8a497b2d09f6 > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 58ee226a3819d6796a169156320c10677e35611a > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ee8f5423810c60b2075e6b98ba8cda36393ae5cc > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2a2b499905a788eb59f5824bc66b487f91e838f1 > > Diff: https://reviews.apache.org/r/35954/diff/ > > > Testing > ------- > > ./rbt post -o > > > Thanks, > > Zameer Manji > > --===============5618385625958715253==--