Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A4E1181B8 for ; Thu, 25 Jun 2015 18:34:09 +0000 (UTC) Received: (qmail 91857 invoked by uid 500); 25 Jun 2015 18:34:09 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 91807 invoked by uid 500); 25 Jun 2015 18:34:09 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 91781 invoked by uid 99); 25 Jun 2015 18:34:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jun 2015 18:34:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E3503AAC37; Thu, 25 Jun 2015 18:34:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8516261476415725882==" MIME-Version: 1.0 Subject: Re: Review Request 35842: Use java.util.Optional and streams in LockManager From: "Zameer Manji" To: "Bill Farner" , "Zameer Manji" Cc: "Kevin Sweeney" , "Aurora" Date: Thu, 25 Jun 2015 18:34:07 -0000 Message-ID: <20150625183407.20383.87721@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35842/ X-Sender: "Zameer Manji" References: <20150625183221.3114.22428@reviews.apache.org> In-Reply-To: <20150625183221.3114.22428@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============8516261476415725882== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89407 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On June 25, 2015, 11:32 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35842/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 11:32 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Use java.util.Optional and streams in Lock*. > > Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API > > > Diffs > ----- > > src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53 > src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761 > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca > src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386 > src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b > src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a > src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965 > > Diff: https://reviews.apache.org/r/35842/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > > --===============8516261476415725882==--