Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A05A61852B for ; Tue, 23 Jun 2015 19:46:07 +0000 (UTC) Received: (qmail 52595 invoked by uid 500); 23 Jun 2015 19:46:07 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 52541 invoked by uid 500); 23 Jun 2015 19:46:07 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 52518 invoked by uid 99); 23 Jun 2015 19:46:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2015 19:46:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 722511DFC3F; Tue, 23 Jun 2015 19:46:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6325592540300209668==" MIME-Version: 1.0 Subject: Re: Review Request 35761: Refactoring TaskLauncher. From: "Bill Farner" To: "Bill Farner" Cc: "Maxim Khutornenko" , "Aurora" Date: Tue, 23 Jun 2015 19:46:06 -0000 Message-ID: <20150623194606.20383.37213@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35761/ X-Sender: "Bill Farner" References: <20150623183510.20383.32701@reviews.apache.org> In-Reply-To: <20150623183510.20383.32701@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora --===============6325592540300209668== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89039 ----------------------------------------------------------- Ship it! src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (line 233) s/manager/handler/ - Bill Farner On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35761/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 6:35 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1334 > https://issues.apache.org/jira/browse/AURORA-1334 > > > Repository: aurora > > > Description > ------- > > Replacing TaskLauncher abstraction with TaskStatusUpdateManager. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java ae31bdb587c0ea8380fc15c71fcf34e7e19405a6 > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java cd55a6ee7424873c3e615d95422c9ecab6442f46 > src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 17b358533853596f0a577958a3a7303fa61bf299 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 4f7a1bec8c32aef4b5f435c760f69de13888ea9d > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 126001a90c819f9b3bfd448a060102bcef8b2a35 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java e4e158721e0bdc7ed8a02eea24f4915ab937b9c7 > > Diff: https://reviews.apache.org/r/35761/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > > --===============6325592540300209668==--