Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4343E18BA6 for ; Fri, 19 Jun 2015 23:26:31 +0000 (UTC) Received: (qmail 37108 invoked by uid 500); 19 Jun 2015 23:26:31 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 37053 invoked by uid 500); 19 Jun 2015 23:26:31 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 37034 invoked by uid 99); 19 Jun 2015 23:26:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2015 23:26:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 56E221DFEA1; Fri, 19 Jun 2015 23:26:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6308231597676802992==" MIME-Version: 1.0 Subject: Re: Review Request 35672: DbTaskStore perf: optimize queries scoped to a task ID. From: "Aurora ReviewBot" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Fri, 19 Jun 2015 23:26:30 -0000 Message-ID: <20150619232630.1515.31823@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35672/ X-Sender: "Aurora ReviewBot" References: <20150619224345.1515.89466@reviews.apache.org> In-Reply-To: <20150619224345.1515.89466@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============6308231597676802992== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35672/#review88600 ----------------------------------------------------------- Master (d240926) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 19, 2015, 10:43 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35672/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 10:43 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1298 > https://issues.apache.org/jira/browse/AURORA-1298 > > > Repository: aurora > > > Description > ------- > > DbTaskStore perf: optimize queries scoped to a task ID. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java cceac8ab14243c7806c48cf5a8d4c1175d7004b8 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 9b30b01e3a9ecdf368910a7270f0d6fed911b2de > src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java 8270407f97f44991dcfa47263c4287c58ac558f1 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 4b67f6ba03d299ed3de73bb5ea69d949364835b3 > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 7c27f374b1143c82131c19448c3236f3dfb96667 > > Diff: https://reviews.apache.org/r/35672/diff/ > > > Testing > ------- > > Scheduling benchmark results with MemTaskStore: > ``` > ClusterFullUtilizationBenchmark.runBenchmark N/A thrpt 10 541318.648 ± 25645.908 ops/s > InsufficientResourcesSchedulingBenchmark.runBenchmark N/A thrpt 10 57782.604 ± 1896.717 ops/s > LimitConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 4040.842 ± 42.494 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 55.713 ± 1.078 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 55.160 ± 1.434 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 54.352 ± 3.150 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 53.149 ± 1.026 ops/s > ValueConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 56678.838 ± 1818.328 ops/s > ``` > > With DbTaskStore before this change: > ``` > ClusterFullUtilizationBenchmark.runBenchmark N/A thrpt 10 42070.261 ± 846.323 ops/s > InsufficientResourcesSchedulingBenchmark.runBenchmark N/A thrpt 10 19909.569 ± 516.249 ops/s > LimitConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 2956.306 ± 24.422 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 54.233 ± 1.455 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 54.970 ± 1.027 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 53.516 ± 1.172 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 45.404 ± 2.238 ops/s > ValueConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 16391.602 ± 752.267 ops/s > ``` > > With DbTaskStore after this change: > ``` > ClusterFullUtilizationBenchmark.runBenchmark N/A thrpt 10 149589.434 ± 3553.202 ops/s > InsufficientResourcesSchedulingBenchmark.runBenchmark N/A thrpt 10 29268.634 ± 1072.366 ops/s > LimitConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 3187.037 ± 25.248 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 56.504 ± 0.575 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 54.710 ± 1.396 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 54.777 ± 1.244 ops/s > PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 45.155 ± 1.602 ops/s > ValueConstraintMismatchSchedulingBenchmark.runBenchmark N/A thrpt 10 23351.751 ± 509.439 ops/s > ``` > > While we lack formal acceptance criteria for DbTaskStore on these benchmarks, i believe these should be considered acceptable. > > > Thanks, > > Bill Farner > > --===============6308231597676802992==--