Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B8711809E for ; Thu, 18 Jun 2015 21:40:08 +0000 (UTC) Received: (qmail 92923 invoked by uid 500); 18 Jun 2015 21:40:08 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 92883 invoked by uid 500); 18 Jun 2015 21:40:08 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 92806 invoked by uid 99); 18 Jun 2015 21:40:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2015 21:40:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8097C1DFE6A; Thu, 18 Jun 2015 21:40:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3211037433636269720==" MIME-Version: 1.0 Subject: Re: Review Request 35627: Explicitly bind SessionContext. From: "Kevin Sweeney" To: "Bill Farner" Cc: "Kevin Sweeney" , "Aurora" Date: Thu, 18 Jun 2015 21:40:07 -0000 Message-ID: <20150618214007.1512.8605@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35627/ X-Sender: "Kevin Sweeney" References: <20150618213524.1515.73940@reviews.apache.org> In-Reply-To: <20150618213524.1515.73940@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora --===============3211037433636269720== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ ----------------------------------------------------------- (Updated June 18, 2015, 2:40 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1352 https://issues.apache.org/jira/browse/AURORA-1352 Repository: aurora Description (updated) ------- Explicitly bind SessionContext. Discussion on bugs like this and a potential solution (enabling `requireExplicitBindings`) are here: https://github.com/google/guice/issues/740 Diffs ----- src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java c89ff0fed60af04f04177e9cdfba6a24b62c2e97 src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 57132ac480702c93934ada198475203b0648ad6a src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 0a842cb9cdd266690b2d3103126e831fe07b1735 src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 4d6043a402a761fe44239e33b83c1c8872fe7068 Diff: https://reviews.apache.org/r/35627/diff/ Testing ------- Ran kerberos e2e test. Thanks, Kevin Sweeney --===============3211037433636269720==--