aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 35932: Remove unnecessary uses of type witness.
Date Fri, 26 Jun 2015 18:03:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89531
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On June 26, 2015, 10:50 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35932/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 10:50 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Note that this does not remove _all_ type witnesses, as the compiler still relies on
them in several cases.  For example, chained method calls cannot compile without them:
> 
> ```
> ImmutableSet.<String>builder()
>   .add('a')
>   .add('b')
>   .build()
> ```
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 308bbd92943e331179bc5fad1f3fa0febba5ed1c

>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java d3e1295db9b933b5ab60d6446dfea453c6051795

>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 3413b0a480073f39bc01a60bc93b211660d9e278

>   src/main/java/org/apache/aurora/GuiceUtils.java 5d0af1ebdccd0d0782f0fbc53d046a338c450167

>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 9e1f35a12205065f2f0cc783a49e14384bc4d50a

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 26093ef35f18eda5b05fe2a9351ac80fbeca3dc8

>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 538cb755a5f80b9e70e3069205f219558053da9b

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 968aca6053a722dbaec6c5832c09e0816ae069ae

>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java f0dea48b3df69dedf620a55573731ed9451369c3

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java f5a18338748da7c443b2fd2ec3a72adf75e7387f

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java cd016af5621be76190ead81921096aae837b59c0

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
c1114a411c32c25785adc93e594ee8e291025969 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 41591b80ee6d078e1c2beb5d98c7a7584ce173e2

>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 7f166e2ec24f66a9ab0c35e3c65af45e461943f9

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b777777b0ebbf303778e528b16ff3db1aa4e76f1

>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java df180a4f9dff75a04ae104462c219444ef605d9a

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 770672c85c06aaf4356b3b3580428b0323edb9d3

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3

>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java bd74f892dde65e957f125a17979ee6c582b3043f

>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java ecba276f1882162d9578e0829b2139040876c7d0

>   src/main/java/org/apache/aurora/scheduler/http/Cron.java fd658e1ac5e73ef0c61c82685f6373c5f0eb6640

>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java fcf5e4419b9908281858e591c916c586c707c6cd

>   src/main/java/org/apache/aurora/scheduler/http/Mname.java d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c

>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java b224983159c4979800fa384bbb082adc7b330b4c

>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
7425b93f476ca1228a233a56363136f9e586a5e5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 5bf4d9a659942c65290442fdcd4749bda046bfd8

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7453680af5a518012f9779f82d0349e897c04994

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java a6d7ab748aeb050f93f817e3b084b03d34a58d9d

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 1b8733bff69aef5a7db6bc7d137932a69717275a

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 48d0ff667cf97002795b97c235b9e9e34f8e5018

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java e5c0322007c8d9424b96016c9075790c69cf2cf5

>   src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 97f9ee81ed18a961e6df4916d9ede1d89f90ded1

>   src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
0a519be65f90cb730f6bda1e6d7b019f0f15252b 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java b87157562045247f8f0aa43f04ae590a6c09a7e1

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 41e144b9c08500867bab8854770f778e6a211b19

>   src/main/java/org/apache/aurora/scheduler/thrift/Responses.java ffca661e20a9aedb2699a9dd64267375283500ac

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9af379c36d2e3e44f462ed5d431f8a497b2d09f6

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 3490394731fe46ccd6691530c03d6b6f9b817573

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java d29cbaecdfd9c05214d5ea66f9ff63a06fbffe86

>   src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java 3893e3dd397aa64252179e83fd38f2f388d406fe

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java b553f97662119b42835ad646b5d187c5550ee516

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 3b9919d635af3304960c8d510ffcfe764a692e07

>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 88a25e67baaa04449bc06e43624747b47616e0be

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java dc085879d14395e6de76dfe03fbc296756f5d880

>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 6815f67ade1446b1ca0d7a13df4ef2d014d59a3f

>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 927a7d131a385702e25947b6a87170f6302aa983

>   src/main/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategy.java 67d595bd81c2e90178b5b9179974190a8ae17322

>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 7d8f848cc8a6fa9669a8a0377590f05b91985064

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 8476b3409297c50262bfb62142393b3390d2d0c4

>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 9d1e2513580e45d5cdd47b4ebea999eaba61c6ed

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 256ee7700a539575b143cbe8de4803e4c99b000e

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 975920af695f1d4590c3e12ab204b55928dfd91a

>   src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 1a0f14c0945c2510685d9e2667e3c3ba509f4bbb

>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7dc03b6bbad348c5d8c0efed7e7f61a3764f0755

>   src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java f73b2c69ef99d3296e17703e1685a044c48b8587

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 53b21cbb706b110e8b529d34e436f5eeb10b6071

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java f3485414690458bd70c10e5e1ff5b31323c115e8

>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 5772e15468a578d17e9323b57ceed47a638f2432

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java 47347762b2cdfc3e7d8108d3febe4c8152665059

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
0280a0b54f9a75c72fd079a6ff2b83d966e58a74 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimFilterTest.java
67dfb82d1a35e1981e8a90788a3821ea083e5298 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 6ecdbd17898e2df4addd93fe03f536b14a65a638

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
9d3820a72997a03b25701a2d4ac0691a15734a66 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java ed9a2878fece0ffc75b333bdd850d6b59e913a41

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
abbd23dd3ee4382565ce846eb035e2aa502badae 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java d6febb8998e05257cabe8d193cefa0b6c79f197e

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java b9e16578b27de2985d24c25aae507b3540fcd3ff

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java abb915d722235c889ce4a7dbd10238cf39affb6a

>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 0e0fabb3d4cb97ad3a33b5904348eceab54778ee

>   src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java 6b360626dbcf96b60e5a408d9d4b605e78d55d56

>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 15bb13bf259d1fcd08e51ceda8dcd3e029a9eadd

>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 703b02698191cbc0e5a911ed6cf4dbfc5de286cf

>   src/test/java/org/apache/aurora/scheduler/http/LocksTest.java 55fbc55d5218b601472bce979714e33be9f88369

>   src/test/java/org/apache/aurora/scheduler/http/MnameTest.java cf61dd1eee17c5bb44e96d31452d773165d3cce2

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 53ba949691768078ac17846b70d1baf440c444d4

>   src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java
fda16442b8eb1611cabb77f1c68619dfde1f83f2 
>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 5b6e0649ea07136817001eb23fdbdeb6f2a8473e

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java f08c79932f2ff9ed64b273a432c7d33c05ad95bd

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9

>   src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 09593b15c9bd711530ddcb5508ed85b58a2ebe02

>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 0724278195bb47cd719f51568f112d533551e042

>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 210bafd5911d03855758a8c2604feb7473176bbe

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 58ee226a3819d6796a169156320c10677e35611a

>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164

>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d

>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 1b5a5a87557c08dc818dcb58968381f665b8c03b

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
0d54049c822b6f24871745b7be2cf43eeca142f3 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java ff0ef021b3d0d7df5f37d14915a8f783672cde6a

>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 702a01abaab5554319da6e6700b870fe6692fd46

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java b7326a629c471f319b8396aac1046ce8b8e9598c

>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 7b12d642184e09923dd0a551ad38348cb7f2e2af

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 3a8e0d9931d153fe9297fc2bac0e48b74a2c604f

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 09e4208afd5f811bae1531642fef63fd6e0d26bf

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java db508cace922b20a19081a1d918cc082b255cd02

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 550deae7020d0f547e81188e457e5cf2fe05caef

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 5152448e1a71aafe24dba6498b287bd1aae30b24

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java a0bd6e1360ee27c368f8a6f2fd5711d22feca14d

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java 0bfb4d4d3272c2da00bd9fe97c9bf9a950e9c89e

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java b24fef95c98b32d162a8e68fc46349dded492c34

>   src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java 31feaea7ba74350fc199333a2384419ec05f1816

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java d4aaa670341a226ff3e51309843db1f3ff5e3d4e

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java e45594665a29ade8adb4a735ccc176a52e3d49dc

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java c183acfbca0e5b87295730a77868cc37f43d164b

>   src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 4d447d348606e29ae2536974db98f82fa199a877

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java 58256afafd12e5de234755969605861891af4daf

>   src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java e5e889a54acf1344b31459abb19b9aff163ba9e9

>   src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 916483b7b0876c671cdc67dc60734804b05b2317

>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 48179b843e3b2d4333230f0a9269f28dcd009a31

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 4786beaf03ec5c1645b112d391064d545a9a7cb5

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
71b09b1fddc5faa7960ade43929cb57eec3243dd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 5c853002ca02b1da5b0f7075e49627157abb57e4

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
22a15460e4d16d79cb0ea873ad0e826035d9ead8 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
793684c93b61db68798f2516926cca18591e1c05 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
dac9af2ebbfe5f645f2e56330f3f0929713b54cf 
>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 11283031a2288aee8b41ff3c57e71315de0cd622

>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java ddec9e63b48a525780747bcb52f80abe1b200726

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 33dd9f1c77c3778af69e766e3c0b91dfb5d17f46

>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java d32b40a9b374eeed280a552508c98efeef460ecb

>   src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java d6e855b879e7909e8ba66c03ed34c845bf978a8f

> 
> Diff: https://reviews.apache.org/r/35932/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message