aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 35886: Remove static modifier from test case.
Date Thu, 25 Jun 2015 19:22:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35886/#review89414
-----------------------------------------------------------

Ship it!


Master (ca15f25) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 25, 2015, 6:50 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35886/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 6:50 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove static modifier from test case, which was introduced in the last revision to https://reviews.apache.org/r/35842/
> 
> This fixes
> 
> [ant:checkstyle] /home/ksweeney/workspace/aurora/src/test/java/org/apache/aurora/GuavaUtilsTest.java:23:1:
Utility classes should not have a public or default constructor.
> 
> 
> Diffs
> -----
> 
>   src/test/java/org/apache/aurora/GuavaUtilsTest.java 065a4bac48b7264c1c6aaf228c684f813f2a39ea

> 
> Diff: https://reviews.apache.org/r/35886/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message