aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 35813: Removing GC executor code.
Date Wed, 24 Jun 2015 01:42:08 GMT


> On June 24, 2015, 12:31 a.m., Brian Wickman wrote:
> > slightly overzealous deleting.  the thermos gc stuff should still be part of the
thermos toolchain.

Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a
task does not seem to be a critical feature (in fact it's currently broken AURORA-1347) but
comes with a maintenance burden. Is there a particular reason to hold on to it?


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35813/#review89104
-----------------------------------------------------------


On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35813/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 12:22 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-1333
>     https://issues.apache.org/jira/browse/AURORA-1333
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing GC executor code.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482

>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa

>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   src/main/python/apache/aurora/executor/BUILD cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b

>   src/main/python/apache/aurora/executor/bin/BUILD 0fbb0f88881ee63499d9ce36150ae5e68fcc8a9e

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 8093717266f8620ebc6ef4c028ac8c87ab8d22be

>   src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5

>   src/main/python/apache/thermos/cli/commands/BUILD 1dae8c981bd750807ddd1b6071e232ff2697537d

>   src/main/python/apache/thermos/cli/commands/gc.py 23d9ff4d2048b4f2d80ea62c54e58e8d768e11c0

>   src/main/python/apache/thermos/cli/main.py f20f612790550b77ee3dc969c37317b014a64972

>   src/main/python/apache/thermos/core/BUILD efb68e84cf547cb9505a8caf5b47be394dee5145

>   src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436

>   src/main/python/apache/thermos/core/inspector.py 4fe8aa31215a12b9a53e885697b4dd4e78c1f35f

>   src/main/python/apache/thermos/monitoring/BUILD 633dd95f9d193b1f377ab5d6cdfcdca7bdaa610f

>   src/main/python/apache/thermos/monitoring/garbage.py aa5a2729ae6c94b6a270d97425767ccee121e588

>   src/test/python/apache/aurora/executor/BUILD f415ecc77022b34f053c35272d004e133803d702

>   src/test/python/apache/aurora/executor/bin/BUILD 2caab2aec136ede9b51ce3bdd0d139270024ba48

>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d4c1d572663039eb742f70de1e06d708eb0b769a

>   src/test/python/apache/aurora/executor/test_gc_executor.py 17d359054d1fc33f79a7612162064abd335ccf81

>   src/test/python/apache/thermos/cli/commands/test_import.py 74d9a32cf85a9e49cfbc596a7d6d44393df14e7a

>   src/test/python/apache/thermos/monitoring/BUILD 89030d0e25e8eb3f4d4eec6a0d0a0fc3dfd43481

>   src/test/python/apache/thermos/monitoring/test_garbage.py 4309c46a3af5f12c8eb3192e3156348fa7c0db23

> 
> Diff: https://reviews.apache.org/r/35813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message