aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 35761: Refactoring TaskLauncher.
Date Tue, 23 Jun 2015 17:55:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35761/#review89008
-----------------------------------------------------------


LGTM overall, will give a ship once the rebase comes out green.


src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java (line 164)
<https://reviews.apache.org/r/35761/#comment141605>

    Accessing the Impl suggests an encapsulagion problem.  Can you use the interface instead?



src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java (line 21)
<https://reviews.apache.org/r/35761/#comment141604>

    How about `TaskStatusReceiver` or `TaskStatusHandler`?



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java (line 176)
<https://reviews.apache.org/r/35761/#comment141608>

    Please include a comment explaining the rationale behind the default.


- Bill Farner


On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35761/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1334
>     https://issues.apache.org/jira/browse/AURORA-1334
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Replacing TaskLauncher abstraction with TaskStatusUpdateManager.
> 
> Will not apply cleanly. Depends on https://reviews.apache.org/r/35760/.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 4c63cc7af2fb5702fa649ce2cd4ee619139223e2

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7

>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java cd55a6ee7424873c3e615d95422c9ecab6442f46

>   src/main/java/org/apache/aurora/scheduler/TaskStatusUpdateManager.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 6bfbf0c76399d569ac762a7b433a6c576bf0ee87

>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 4f7a1bec8c32aef4b5f435c760f69de13888ea9d

>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 126001a90c819f9b3bfd448a060102bcef8b2a35

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java e4e158721e0bdc7ed8a02eea24f4915ab937b9c7

> 
> Diff: https://reviews.apache.org/r/35761/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message