aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 35745: Allow equals in bound variables passed via cmdline
Date Mon, 22 Jun 2015 22:17:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35745/#review88863
-----------------------------------------------------------


Master (3351b09) is red with this patch.
  ./build-support/jenkins/build.sh

  Using cached twitter.common.process-0.3.0.tar.gz
Collecting twitter.common.log==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.log-0.3.0.tar.gz
Collecting twitter.common.util==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
  Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang,
twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil,
twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections,
twitter.common.app, twitter.checkstyle
  Running setup.py install for pyflakes
  Running setup.py install for pep8
  Running setup.py install for smmap
  Running setup.py install for gitdb
  Running setup.py install for GitPython
  Running setup.py install for twitter.common.lang
  Running setup.py install for twitter.common.string
  Running setup.py install for twitter.common.process
  Running setup.py install for twitter.common.options
  Running setup.py install for twitter.common.dirutil
  Running setup.py install for twitter.common.log
  Running setup.py install for twitter.common.contextutil
  Running setup.py install for twitter.common.util
  Running setup.py install for twitter.common.collections
  Running setup.py install for twitter.common.app
  Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0
twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0
twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
E501:ERROR   src/test/python/apache/aurora/client/cli/util.py:299 line too long (114 >
100 characters)
     |          processes = [Process(name = 'hello_world', cmdline = 'echo {{thermos.ports[http]}}
{{flags_binding}}')],



I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On June 22, 2015, 10:09 p.m., Michael Leinartas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35745/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 10:09 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Allow equals in bound variables passed via cmdline
> 
> The parsing for the --bind parameter splits the parameter value on equals and enforces
only two elements. This prevents parameters whose value contains an equals to be passed.
> 
> Example case:
>     HELLO_WORLD = Job(
>          name = 'hello',
>          role = 'bozo',
>          cluster = 'west',
>          environment = 'test',
>          instances = 1,
>          update_config = UpdateConfig(
>            batch_size = 1,
>            restart_threshold = 60,
>            watch_secs = 45,
>            max_per_shard_failures = 2,
>          ),
>          task = Task(
>            name = 'test',
>            processes = [Process(name = 'hello_world', cmdline = 'echo {{flags}}')],
>            resources = Resources(cpu = 0.1, ram = 64 * MB, disk = 64 * MB),
>          )
>        )
>        jobs = [HELLO_WORLD]
>        
> 
> aurora job create --bind flags=-myflag=value west/bozo/test/hello ./hello_world.aurora
> 
> Instead, the split() should use the maxsplit parameter to limit to 1 match and leave
additional equals signs in the parameter
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/options.py f8ac25287e296bcec89d3701738c7dd06ffae133

>   src/test/python/apache/aurora/client/cli/test_create.py 9f32ca3474ea51529217db29b88911010fa73602

>   src/test/python/apache/aurora/client/cli/util.py 053c9a56248848478ca2fe6ab2c12e24c3d93c13

> 
> Diff: https://reviews.apache.org/r/35745/diff/
> 
> 
> Testing
> -------
> 
> Added a new binding to UNBOUND_CONFIG and a matching --bind parameter with an equals
sign in it to test_simple_successful_create_job_with_bindings (test_create.py)
> 
>     $ ./pants test --test-pytest-options='-k _bindings' src/test/python/apache/aurora:all
> passes
> 
> 
> Thanks,
> 
> Michael Leinartas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message