aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 35580: Fix symlink duplicates from MesosPathDetector.
Date Wed, 17 Jun 2015 21:23:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35580/#review88278
-----------------------------------------------------------

Ship it!


+1 on test coverage too

- Joe Smith


On June 17, 2015, 2:17 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35580/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 2:17 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1353
>     https://issues.apache.org/jira/browse/AURORA-1353
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix symlink duplicates from MesosPathDetector.  Also added thread ids to TaskResourceMonitor
for better /threads debugging.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/path_detector.py ba85d5c969d3f1f62d3f898bed83d930e2994bd2

>   src/main/python/apache/thermos/monitoring/resource.py c1d7804fe0896d8b92aa565d6dd5295fa58efd3f

>   src/test/python/apache/aurora/executor/common/test_path_detector.py 86460bb6499596964124bec85d74ca9dba7d2c7c

>   src/test/python/apache/thermos/monitoring/test_resource.py a7ab360d7bc0022b115b9059b16d76b8923d5e23

> 
> Diff: https://reviews.apache.org/r/35580/diff/
> 
> 
> Testing
> -------
> 
> Verified we realpath the paths prior to returning from path detector.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message